You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add a "play" button to run python file in terminal #5321
Luciana Abud (@luabud)Kartik Raj (@karrtikr) /cc
I prefer and have always pushed for the same solution that had been suggested by Dan Taylor (@qubitron).
Adding a setting seems unnecessary. I.e. if we detect the coderunner extension is installed why can't we just hide the button, less settings, less documentation... Etc..
Raising this as I'm not convinced @quibtron comment has been taken into account.
The feedback from users was to have a setting to hide the play button, so it's clear we don't need to be any fancier than that. Before we hide our button, we first need to contribute to the code runner extension to fix it so that they use the correct python path. Either way some action is needed before we can finish this work in the next sprint.
Activity
DonJayamanne commentedon Apr 17, 2019
We might instead want to contribute to existing extension.
brettcannon commentedon Jun 26, 2019
Provide a setting to hide the button (on by default).
33 remaining items
DonJayamanne commentedon Sep 11, 2019
Why?
karrtikr commentedon Sep 11, 2019
Don Jayamanne (@DonJayamanne) Here #6921
DonJayamanne commentedon Sep 11, 2019
What about the comment here #6921 (comment) ?
Luciana Abud (@luabud) Kartik Raj (@karrtikr) /cc
I prefer and have always pushed for the same solution that had been suggested by Dan Taylor (@qubitron).
Adding a setting seems unnecessary. I.e. if we detect the coderunner extension is installed why can't we just hide the button, less settings, less documentation... Etc..
Raising this as I'm not convinced @quibtron comment has been taken into account.
karrtikr commentedon Sep 11, 2019
Don Jayamanne (@DonJayamanne) I agree.
qubitron commentedon Sep 11, 2019
The feedback from users was to have a setting to hide the play button, so it's clear we don't need to be any fancier than that. Before we hide our button, we first need to contribute to the code runner extension to fix it so that they use the correct python path. Either way some action is needed before we can finish this work in the next sprint.
DonJayamanne commentedon Sep 11, 2019
This should fix the problem. Along with automatically hiding out button. We just need to decide on an approach.
luabud commentedon Sep 16, 2019
For now I'm proposing that we hide this button if the code runner extension is enabled. Also, we could use these icons:
https://github.com/microsoft/vscode-icons/blob/master/icons/light/play.svg
https://github.com/microsoft/vscode-icons/blob/master/icons/dark/play.svg
luabud commentedon Oct 15, 2019
Closing as this has been shipped in version 2019.10.41019.