New workspace virtual environments are not discovered until VS Code reloads #656

Activity

1. Brett Cannon (brettcannon)

   added

   feature-requestRequest for new features or functionalityRequest for new features or functionality

   awaiting 2-PR

   feature-extension

   on Jan 30, 2018
2. brettcannon commented on Sep 20, 2018

   

   Brett Cannon (brettcannon)

   on Sep 20, 2018

   Member

   More actions

   We are going to scope this to just virtual environments created in the workspace folder (should take into consideration the fact that pipenv can create its virtual environment locally when a certain environment variable is set).
3. Don Jayamanne (DonJayamanne)

   changed the title [-]New virtual environments are not discovered until VS Code resets[/-] [+]New workspace virtual environments are not discovered until VS Code reloads[/+] on Sep 20, 2018
4. DonJayamanne commented on Sep 20, 2018

   

   Don Jayamanne (DonJayamanne)

   on Sep 20, 2018

   Last edited by DonJayamanne

   More actions

   Solution:

   • Add (vscode) file monitor for local workspace
   • If a file/folder is created, and check if we have an interpreter in there
     Use lookForInterpretersInDirectory
   • If there are no interpreters, then get out.
   • If we have an interpreter, then raise an event indicating the fact interpreters need to be refreshed
   • Add a handler for the above event in the CacheableLocatorService
   • In the event handler, clear the map promisesPerResource
5. Brett Cannon (brettcannon)

   added this to the 2018, week 40 - October Sprint 1 milestone on Oct 3, 2018
6. Brett Cannon (brettcannon)

   modified the milestones: 2018, week 40 - October Sprint 1, 2018, week 42 - October Sprint 2 on Oct 17, 2018
7. Don Jayamanne (DonJayamanne)

   self-assigned this

   on Oct 26, 2018
8. Brett Cannon (brettcannon)

   closed this as completedon Oct 30, 2018
9. Don Jayamanne (DonJayamanne)

   reopened this on Oct 31, 2018
10. Brett Cannon (brettcannon)

    modified the milestones: 2018, week 42 - October Sprint 2, 2018, week 44 - Nov sprint 1 on Oct 31, 2018
11. Don Jayamanne (DonJayamanne)

    added a commit that references this issue on Nov 1, 2018

    Progress indicator when loading interpreters and speed up detection o…

    ...

    35ab321
12. Brett Cannon (brettcannon)

    added

    validate fix

    on Nov 5, 2018
13. brettcannon commented on Nov 5, 2018

    

    Brett Cannon (brettcannon)

    on Nov 5, 2018

    Member

    More actions

    This doesn't seem to re-trigger if a virtual environment is deleted. Is that expected?
14. Brett Cannon (brettcannon)

    closed this as completedon Nov 6, 2018
15. Don Jayamanne (DonJayamanne)

    removed

    validate fix

    on Nov 7, 2018
16. lock

    locked as resolved and limited conversation to collaborators on Dec 5, 2018