Skip to content

Code Lens cannot find the reference in Object Shorthand property names #117021

Closed
Closed
Code Lens cannot find the reference in Object Shorthand property names#117021
Assignees
mjbvz
Labels
bugIssue identified by VS Code Team member as probable bugtypescriptTypescript support issuesupstream-issue-linkedThis is an upstream issue that has been reported upstreamverifiedVerification succeeded
Milestone
September 2021

Description

@nztraveler
husihao (nztraveler)
opened on Feb 19, 2021

Version: 1.53.2 (user setup)
Commit: 622cb03
Date: 2021-02-11T11:48:04.245Z
Electron: 11.2.1
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Windows_NT x64 10.0.19041

Steps to Reproduce:
There are three simple javascript files, and the code lens of the module a.js can only find 1 reference in c.js.
In the b.js, the a is referenced in the way of Object Shorthand property names, which is not be found in code lens.

a.js

const a = '123';  
export default a;

b.js

import a from './a.js';  
// referenced in the way of Object Shorthand property names, cannot be found by code lens.  
console.log({a});

c.js

import a from './a.js';  
console.log(a);

image

Does this issue occur when all extensions are disabled?: Yes

Activity

  1. VS Code Issue Triage Bot (vscode-triage-bot)
    assigned
    Matt Bierner (mjbvz)
    on Feb 19, 2021
  2. Matt Bierner (mjbvz)
    added
    bugIssue identified by VS Code Team member as probable bug
    on Feb 19, 2021

  3. mjbvz commented on Feb 19, 2021

    @mjbvz
    Matt Bierner (mjbvz)
    on Feb 19, 2021
    Contributor

    Also happens in a single file:

    export const abc = 123;

console.log({ abc });
  4. Matt Bierner (mjbvz)
    added
    upstream-issue-linkedThis is an upstream issue that has been reported upstream
    typescriptTypescript support issues
    on Feb 19, 2021
  5. Matt Bierner (mjbvz)
    added this to the September 2021 milestone on Sep 29, 2021

  6. mjbvz commented on Sep 29, 2021

    @mjbvz
    Matt Bierner (mjbvz)
    on Sep 29, 2021
    Contributor

    Should be fixed by updates TS change

    To verify:

    1. Install typescript@next in a workspace
    2. Switch to the workspace version of TypeScript
    3. Confirm that you now see the correct reference count for the examples above
  7. Matt Bierner (mjbvz)
    closed this as completedon Sep 29, 2021
  8. Johannes Rieken (jrieken)
    added
    verifiedVerification succeeded
    on Sep 30, 2021

  9. nztraveler commented on Oct 12, 2021

    @nztraveler
    husihao (nztraveler)
    on Oct 12, 2021
    Author

    Matt Bierner (@mjbvz) Thanks, it works with your suggested verify step. Nice work!

  10. github-actions
    locked and limited conversation to collaborators on Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugtypescriptTypescript support issuesupstream-issue-linkedThis is an upstream issue that has been reported upstreamverifiedVerification succeeded

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions