Skip to content

Automatically show inline values if an inline values provider is registered #119560

Closed
Closed
Automatically show inline values if an inline values provider is registered#119560
Assignees
isidorn
Labels
debugDebug viewlet, configurations, breakpoints, adapter issuesfeature-requestRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code Insidersverification-neededVerification of issue is requestedverifiedVerification succeeded
Milestone
April 2021

Description

@weinand
Andre Weinand (weinand)
opened on Mar 23, 2021

If a user does not have an explicit "debug.inlineValues" setting, we should automatically enable inline values if an inline values provider is registered.

see #105690 (comment)

Activity

  1. Andre Weinand (weinand)
    added
    feature-requestRequest for new features or functionality
    debugDebug viewlet, configurations, breakpoints, adapter issues
    on Mar 23, 2021
  2. Andre Weinand (weinand)
    added this to the April 2021 milestone on Mar 23, 2021
  3. Andre Weinand (weinand)
    assigned
    Isidor Nikolic (isidorn)
    on Mar 23, 2021

  4. isidorn commented on Mar 23, 2021

    @isidorn
    Isidor Nikolic (isidorn)
    on Mar 23, 2021

    Yes this makes sense, for this we can change the debug.inlineValue to be true | false and add a new default value auto.

    auto would mean it is off unless there is a value provider registered.
    That way we will still give the option for the user to turn it off even if a provider is registered.

  5. testforstephen commented on Mar 24, 2021

    @testforstephen
    Jinbo Wang (testforstephen)
    on Mar 24, 2021

    I like the idea of adding a new default value auto.

  6. Isidor Nikolic (isidorn)
    closed this as completedin e09a240on Mar 29, 2021
  7. Isidor Nikolic (isidorn)
    added
    verification-neededVerification of issue is requested
    on Mar 29, 2021
  8. VS Code Issue Triage Bot (vscode-triage-bot)
    added
    unreleasedPatch has not yet been released in VS Code Insiders
    on Mar 29, 2021

  9. isidorn commented on Mar 29, 2021

    @isidorn
    Isidor Nikolic (isidorn)
    on Mar 29, 2021

    I just pushed this change as we agreed upon, debug.inlineValue can now be true | false | "auto". "auto" is the default

    Jinbo Wang (@testforstephen) would be great if you can verify this with vscode insiders starting from Friday (once we release a new Insiders build). Thanks!

  10. VS Code Issue Triage Bot (vscode-triage-bot)
    added
    insiders-releasedPatch has been released in VS Code Insiders
    and removed
    unreleasedPatch has not yet been released in VS Code Insiders
    on Apr 1, 2021

  11. testforstephen commented on Apr 7, 2021

    @testforstephen
    Jinbo Wang (testforstephen)
    on Apr 7, 2021

    Tried 04-02 insider version, it works well. Thanks.

    The new auto will enable the inline values by default if Java debugger uses the API to provide inline values.
    And true and false will also turn on/off the inline values.

  12. isidorn commented on Apr 7, 2021

    @isidorn
    Isidor Nikolic (isidorn)
    on Apr 7, 2021

    Jinbo Wang (@testforstephen) great, thanks for trying, adding verified label.

  13. Isidor Nikolic (isidorn)
    added
    verifiedVerification succeeded
    on Apr 7, 2021
  14. github-actions
    locked and limited conversation to collaborators on May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

debugDebug viewlet, configurations, breakpoints, adapter issuesfeature-requestRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code Insidersverification-neededVerification of issue is requestedverifiedVerification succeeded

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions