Repository navigation
Go To Source Definition UX improvements #152252
Description
Following up on TypeScript’s new Go To Source Definition command (d851ea5), I want to track some editor-side UX improvements:
-
Can we replace the error notification for “no source definitions found” with an inline message similar to Go To Definition?
-
Can we somehow indicate when a result is a guess? This is already returned in the protocol response via an
unverifiedproperty, but it is never surfaced to the user. When multiple locations are returned, maybe we could add something to the peek locations UI:
(Note: the
unverifiedflag is also sometimes set in normal Go To Definition responses, so this request is not specific to Go To Source Definition.)When only one location is returned, maybe a notification would suffice, but I would love design input on this.
Activity
mjbvz commentedon Jun 21, 2022
Johannes Rieken (@jrieken) Any thoughts on these? I think we'd have to implement these in core
jrieken commentedon Jun 22, 2022
There is currently no way to express that but it reminds me of #74237 which is about adding a kind-property to references/locations. That would allow us to classify/filter/etc...
No sure how "go to source" is implemented but in case it is using the
editor.action.goToLocations-command than a "no-results-message" can be passed