Skip to content

Experiment with threading AI into extraction refactorings #182779

Closed
Closed
Experiment with threading AI into extraction refactorings#182779
Assignees
mjbvz
Labels
explorationtypescriptTypescript support issues
Milestone
June 2024

Description

@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)
opened on May 17, 2023

Today, TSServer provides several actions for "extract to function" and "extract to local" for both TypeScript and JavaScript. Currently, TSServer just creates a pre-generated name like newLocal or newFunction that's sufficiently unique. While this is fine, it would be interesting if we could use a language model to come up with a useful name and calculate a better name while TypeScript itself calculates the refactoring.

In cases where a language model can "confidently" calculate a new name, that name can replace the contents of the automatically-invoked rename for the refactor.

Activity

  1. Daniel Rosenwasser (DanielRosenwasser)
    assigned
    Matt Bierner (mjbvz)
    on May 17, 2023
  2. Daniel Rosenwasser (DanielRosenwasser)
    added this to the June 2023 milestone on May 17, 2023

  3. spartanatreyu commented on May 18, 2023

    @spartanatreyu
    Jayden Pearse (spartanatreyu)
    on May 18, 2023

    This should be controlled by a setting for sure.

    Here are the outcomes I can see with this feature:

    • A user refactors some code, likes the AI generated name and decides to use it.
    • A user refactors some code and sees the AI generated name, but they want to make a slight tweak to the name.
    • A user reactors some code and doesn't want to use the AI generated names at all.
      • Perhaps the user is consistently getting bad suggestions for the particular thing they are trying to do.
      • Perhaps seeing pre-generated names like newLocal or newFunction is a part of their proofing workflow (with eyeballs, linters, git hooks, or other code analysis tools).
      • The user is against using AI for some other reason
  4. Matt Bierner (mjbvz)
    added
    feature-requestRequest for new features or functionality
    on May 25, 2023

  5. zardoy commented on Jun 1, 2023

    @zardoy
    Vitaly (zardoy)
    on Jun 1, 2023
    Contributor

    I think TypeScript should try to infer name using common naming conventions at least (such as use... or get...), just like vscode-postfix-ts extension does:

    From my experience it covers ~20% of code and can be useful if AI suggestions are slow, unavailable or a user doesn't want to use the AI generated names at all.

  6. Matt Bierner (mjbvz)
    modified the milestones: June 2023, July 2023 on Jun 8, 2023
  7. Matt Bierner (mjbvz)
    modified the milestones: July 2023, August 2023 on Jul 18, 2023
  8. Matt Bierner (mjbvz)
    modified the milestones: August 2023, September 2023 on Aug 29, 2023
  9. Matt Bierner (mjbvz)
    modified the milestones: September 2023, October 2023 on Sep 28, 2023
  10. Matt Bierner (mjbvz)
    modified the milestones: October 2023, November 2023 on Oct 25, 2023

  11. 10 remaining items

  12. Matt Bierner (mjbvz)
    added this to the April 2024 milestone on Mar 25, 2024
  13. Matt Bierner (mjbvz)
    modified the milestones: April 2024, May 2024 on Apr 22, 2024
  14. Matt Bierner (mjbvz)
    modified the milestones: May 2024, June 2024 on May 24, 2024
  15. Daniel Rosenwasser (DanielRosenwasser)
    closed this as completedon Jun 24, 2024
  16. Michael Lively (Yoyokrazy)
    added
    verification-neededVerification of issue is requested
    on Jun 25, 2024

  17. amunger commented on Jun 25, 2024

    @amunger
    Aaron Munger (amunger)
    on Jun 25, 2024
    Collaborator

    Daniel Rosenwasser (@DanielRosenwasser) - is this the newly added behavior?

    image

  18. Aaron Munger (amunger)
    added
    verification-steps-neededSteps to verify are needed for verification
    on Jun 25, 2024
  19. Matt Bierner (mjbvz)
    added
    exploration
    and removed
    feature-requestRequest for new features or functionality
    on Jun 26, 2024

  20. mjbvz commented on Jun 26, 2024

    @mjbvz
    Matt Bierner (mjbvz)
    on Jun 26, 2024
    Contributor

    Marking this as an exploration. We'll create test items for the individual features that came out of it

  21. Michael Lively (Yoyokrazy)
    removed
    verification-neededVerification of issue is requested
    verification-steps-neededSteps to verify are needed for verification
    on Jun 26, 2024
  22. vs-code-engineering
    locked and limited conversation to collaborators on Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

explorationtypescriptTypescript support issues

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions