Skip to content

ctrl + shift + f does not work while in editor #201637

Closed
Closed
ctrl + shift + f does not work while in editor#201637
Assignees
ulugbekna

Description

@bilogic
bilogic
opened on Dec 31, 2023

Does this issue occur when all extensions are disabled?: Yes, see vscode.dev

  • VS Code Version:
  • OS Version:
    Version: 1.85.1
    Commit: 0ee08df
    Date: 2023-12-13T09:49:35.427Z
    Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36

Steps to Reproduce:

  1. See video
  2. ctrl + shift + e works in editor
  3. ctrl + shift + f does not work in editor
  4. But pressing ctrl + shift + f works if in explorer
vid.mp4

Activity

  1. ulugbekna commented on Jan 2, 2024

    @ulugbekna
    Ulugbek Abdullaev (ulugbekna)
    on Jan 2, 2024
    Contributor

    I can't repro, but I see from your screencast that ctrl+shift+f isn't reaching the keybinding service of vscode while in editor, so I suspect chrome or some plugin you have has the same shortcut and processes it before the event reaches vscode.

    Could you try invoking ctrl+shift+e on this website and see if all events are caught? A screencast would be great

  2. Ulugbek Abdullaev (ulugbekna)
    self-assigned this
    on Jan 2, 2024
  3. Ulugbek Abdullaev (ulugbekna)
    added
    info-neededIssue requires more information from poster
    on Jan 2, 2024

  4. bilogic commented on Jan 2, 2024

    @bilogic
    bilogic
    on Jan 2, 2024
    ContributorAuthor

    Thanks for getting back. I tried again and it works as it should now.

    I did check through the keyboard shortcuts of my Chrome extensions before opening this issue, but since it works now, let's consider this closed. I will update again with better info if it comes back.

  5. bilogic
    closed this as completedon Jan 2, 2024

  6. bilogic commented on Jan 3, 2024

    @bilogic
    bilogic
    on Jan 3, 2024
    ContributorAuthor

    The problem is back and here are more thoughts:

    Since ctrl+shift+f reached in VSCode explorer, why would Chrome and its extensions be suspect?

    Here is the screencast you requested, ctrl+shift+e and ctrl+shift+f looks a bit different to me though

    vid.mp4
  7. bilogic
    reopened this on Jan 3, 2024

  8. bilogic commented on Jan 3, 2024

    @bilogic
    bilogic
    on Jan 3, 2024
    ContributorAuthor

    It seems that when the issue occurs, ctrl+shift+f keydown does not reach the webpage

  9. renxida commented on Jan 4, 2024

    @renxida
    Xida Ren (renxida)
    on Jan 4, 2024

    I'm having similar issues, except I'm running VS Code desktop client on windows.

    With the editor focused, I get the following log. It looks like the "f" key isn't reaching KeyBindingService.

    2024-01-04 10:10:21.106 [info] [KeybindingService]: / Soft dispatching keyboard event
2024-01-04 10:10:21.106 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2024-01-04 10:10:21.107 [info] [KeybindingService]: / Received  keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 17, key: Control
2024-01-04 10:10:21.107 [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 5 ('Ctrl')
2024-01-04 10:10:21.107 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2024-01-04 10:10:21.109 [info] [KeybindingService]: / Soft dispatching keyboard event
2024-01-04 10:10:21.109 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2024-01-04 10:10:21.109 [info] [KeybindingService]: / Received  keydown event - modifiers: [ctrl,shift], code: ShiftLeft, keyCode: 16, key: Shift
2024-01-04 10:10:21.109 [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl,shift], code: ShiftLeft, keyCode: 4 ('Shift')
2024-01-04 10:10:21.109 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2024-01-04 10:10:21.574 [info] [KeybindingService]: + Ignoring single modifier ctrl due to it being pressed together with other keys.

    When I focus anywhere other than the editor, I get this

    2024-01-04 10:11:06.718 [info] [KeybindingService]: / Soft dispatching keyboard event
2024-01-04 10:11:06.718 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2024-01-04 10:11:06.718 [info] [KeybindingService]: / Received  keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 17, key: Control
2024-01-04 10:11:06.718 [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 5 ('Ctrl')
2024-01-04 10:11:06.719 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2024-01-04 10:11:06.774 [info] [KeybindingService]: / Soft dispatching keyboard event
2024-01-04 10:11:06.774 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2024-01-04 10:11:06.775 [info] [KeybindingService]: / Received  keydown event - modifiers: [ctrl,shift], code: ShiftLeft, keyCode: 16, key: Shift
2024-01-04 10:11:06.775 [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl,shift], code: ShiftLeft, keyCode: 4 ('Shift')
2024-01-04 10:11:06.775 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2024-01-04 10:11:06.902 [info] [KeybindingService]: / Soft dispatching keyboard event
2024-01-04 10:11:06.903 [info] [KeybindingService]: | Resolving ctrl+shift+F
2024-01-04 10:11:06.903 [info] [KeybindingService]: \ From 3 keybinding entries, matched workbench.action.findInFiles, when: no when condition, source: built-in.
2024-01-04 10:11:06.903 [info] [KeybindingService]: / Received  keydown event - modifiers: [ctrl,shift], code: KeyF, keyCode: 70, key: F
2024-01-04 10:11:06.903 [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl,shift], code: KeyF, keyCode: 36 ('F')
2024-01-04 10:11:06.903 [info] [KeybindingService]: | Resolving ctrl+shift+F
2024-01-04 10:11:06.904 [info] [KeybindingService]: \ From 3 keybinding entries, matched workbench.action.findInFiles, when: no when condition, source: built-in.
2024-01-04 10:11:06.904 [info] [KeybindingService]: + Invoking command workbench.action.findInFiles.
2024-01-04 10:11:07.190 [info] [KeybindingService]: + Ignoring single modifier ctrl due to it being pressed together with other keys.

    and ctrl+shift+f is successfully triggered.

  10. bilogic commented on Jan 5, 2024

    @bilogic
    bilogic
    on Jan 5, 2024
    ContributorAuthor

    I like to emphasize, this issue is very intermittent. Hope we lean on trying to reproduce it rather than classify it as isolated cases.

  11. bilogic commented on Jan 8, 2024

    @bilogic
    bilogic
    on Jan 8, 2024
    ContributorAuthor

    More and more keys are randomly not working, e.g. home, end when typing a commit message, to fix, I had to close the vscode window and open it again. However Chrome did not restart, implying that Chrome extensions were not restarted

  12. bilogic commented on Jan 24, 2024

    @bilogic
    bilogic
    on Jan 24, 2024
    ContributorAuthor

    Each time I face this, I have to press ctrl+shift+e to jump into explorer first, then press ctrl+shift+f works. I can't quite comprehend how this can be caused by Chrome.

  13. renxida commented on Jan 26, 2024

    @renxida
    Xida Ren (renxida)
    on Jan 26, 2024

    (ctrl+shift+f is currently working for me again)
    Thanks bilogic for the ctrl+shift+e idea. Great temporary fix for next time it stops working.

  14. bilogic commented on Jan 26, 2024

    @bilogic
    bilogic
    on Jan 26, 2024
    ContributorAuthor

    Ulugbek Abdullaev (@ulugbekna)

    What other info do you need?

  15. vscodenpa commented on Apr 18, 2024

    @vscodenpa
    VS Code Bot (vscodenpa)
    on Apr 18, 2024

    Hey Ulugbek Abdullaev (@ulugbekna), this issue might need further attention.

    bilogic, you can help us out by closing this issue if the problem no longer exists, or adding more information.

  16. ulugbekna commented on Apr 18, 2024

    @ulugbekna
    Ulugbek Abdullaev (ulugbekna)
    on Apr 18, 2024
    Contributor

    bilogic Sorry for a late reply; the issue got lost in inbox. Can you reproduce this in incognito mode? Does it happen only occasionally or always?

    Xida Ren (@renxida)

    With the editor focused, I get the following log. It looks like the "f" key isn't reaching KeyBindingService.

    Well, it has to be something capturing that keybinding and not passing to vscode. It's unlikely the editor because others don't have that problem. Try seeing if you have any program that could capture that keybinding conditionally.

  17. bilogic commented on Apr 18, 2024

    @bilogic
    bilogic
    on Apr 18, 2024
    ContributorAuthor

    Ulugbek Abdullaev (@ulugbekna) thanks, I have not encountered it for a while now, but will need some time to verify it.

    Meanwhile, is this a PR something you can help approve? #207721

    Thanks!

  18. renxida commented on Apr 18, 2024

    @renxida
    Xida Ren (renxida)
    on Apr 18, 2024

    same. Haven't been an issue for me for a while now.

  19. Ulugbek Abdullaev (ulugbekna)
    closed this as completedon Apr 22, 2024
  20. Ulugbek Abdullaev (ulugbekna)
    removed
    info-neededIssue requires more information from poster
    on Apr 22, 2024

  21. ulugbekna commented on Apr 22, 2024

    @ulugbekna
    Ulugbek Abdullaev (ulugbekna)
    on Apr 22, 2024
    Contributor

    Thanks! Closing for now since it seems fixed

  22. bilogic commented on May 1, 2024

    @bilogic
    bilogic
    on May 1, 2024
    ContributorAuthor

    Ulugbek Abdullaev (@ulugbekna) thanks, would you be able to help with #207721?

  23. ulugbekna commented on May 2, 2024

    @ulugbekna
    Ulugbek Abdullaev (ulugbekna)
    on May 2, 2024
    Contributor

    I'll try

  24. bilogic commented on May 2, 2024

    @bilogic
    bilogic
    on May 2, 2024
    ContributorAuthor

    thanks!

  25. bilogic commented on May 7, 2024

    @bilogic
    bilogic
    on May 7, 2024
    ContributorAuthor

    Ulugbek Abdullaev (@ulugbekna) possible? haha thank you

  26. ulugbekna commented on May 8, 2024

    @ulugbekna
    Ulugbek Abdullaev (ulugbekna)
    on May 8, 2024
    Contributor

    The corresponding issue was closed without getting support, so the PR will not likely be merged.

    cc Benjamin Christopher Simmonds (@benibenj)

  27. bilogic commented on May 8, 2024

    @bilogic
    bilogic
    on May 8, 2024
    ContributorAuthor

    Do you mean not reaching 20 votes? Does every issue have to be voted on this way to be merged?

  28. ulugbekna commented on May 8, 2024

    @ulugbekna
    Ulugbek Abdullaev (ulugbekna)
    on May 8, 2024
    Contributor

    Do you mean not reaching 20 votes?

    Yes

    Does every issue have to be voted on this way to be merged?

    It depends on the area owner -- for this issue, it's Ben cc'ed above.

  29. microsoft
    locked and limited conversation to collaborators on Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions