Skip to content

Adopting code actions ranges for refactorings in TS #204040

Closed
Closed
Adopting code actions ranges for refactorings in TS#204040
Assignees
justschen
Labels
editor-code-actionsEditor inplace actions (Ctrl + .)on-testplan
Milestone
February 2024

Description

@justschen
Justin Chen (justschen)
opened on Feb 1, 2024

adopt #199608 for refactorings

vscode/extensions/typescript-language-features/src/languageFeatures/refactor.ts

Line 343 in e81518d

class InlinedCodeAction extends vscode.CodeAction {

will also be adopted for quick fixes (after adopting, can remove how diagnostics are currently highlighted), source actions, etc.

vscode/extensions/typescript-language-features/src/languageFeatures/quickFix.ts

Line 265 in e81518d

for (const action of allActions) {

Activity

  1. Justin Chen (justschen)
    added
    editor-code-actionsEditor inplace actions (Ctrl + .)
    on Feb 1, 2024
  2. Justin Chen (justschen)
    added this to the February 2024 milestone on Feb 1, 2024
  3. Justin Chen (justschen)
    self-assigned this
    on Feb 1, 2024

  4. justschen commented on Feb 21, 2024

    @justschen
    Justin Chen (justschen)
    on Feb 21, 2024
    CollaboratorAuthor

    this is done for quick fixes in TS. refactorings to be done in TS 5.5

  5. Justin Chen (justschen)
    closed this as completedon Feb 21, 2024
  6. Justin Chen (justschen)
    added
    on-testplan
    on Feb 21, 2024
  7. microsoft
    locked and limited conversation to collaborators on Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

editor-code-actionsEditor inplace actions (Ctrl + .)on-testplan

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions