Salsa does not warn or help when passing in wrong argument type #2442

Activity

1. Alexandru Dima (alexdima)

   assigned

   Erich Gamma (egamma)

   on Jan 27, 2016
2. billti commented on Jan 27, 2016

   

   Bill Ticehurst (billti)

   on Jan 27, 2016

   Member

   More actions

   Correct. We explicitly decided to give no warnings/errors other than syntax errors for JavaScript code. If warnings on incorrect type usage are required, we'd need to spec how and when these would occur in JavaScript, else being based on TypeScript, code such as the below would also be a type error:

   var x = 10;
   x = "ten";
   
   var y = {a:true};
   y.b = false;
   
3. egamma commented on Jan 27, 2016

   

   Erich Gamma (egamma)

   on Jan 27, 2016

   Member

   More actions

   In the existing Code JS language service we gave warnings for the first example above and we didn't receive complaints.

   

   We have also warned about undefined variables, which had issues when users where also using a linter in their project and they defined a global as a global in their linter configuration. The confusion was that they define the global in linter configuration, but our JS service still warned about the global.
4. egamma commented on Jan 27, 2016

   

   Erich Gamma (egamma)

   on Jan 27, 2016

   Member

   More actions

   This issue was moved to microsoft/TypeScript#6658
5. Erich Gamma (egamma)

   closed this as completedon Jan 27, 2016
6. vscodebot

   locked and limited conversation to collaborators on Nov 19, 2017