Skip to content

Support for Custom CompletionItemKind Icons #4201

Closed

Description

I'm currently working on an extension for VS Code to add the functionality of another extension of mine that was created for Visual Studio: Glyphfriend. When I began working on this, I noticed that the CompletionItemKinds enum only seems to support a predefined set of values (e.g. Value,Text,File, etc.).

Is there any way to currently set this glyph to a specific file? Or is there another preferred way that I should look at implementing this type of behavior (either via a different type of provider or through somehow extending the existing CompletionItemKind class)?

Any feedback or recommendations would be appreciated.

Activity

  1. changed the title [-]Support for Custom CompletionItemKind Glyphs[/-] [+]Support for Custom CompletionItemKind Icons[/+] on Mar 14, 2016
  2. sandyarmstrong commented on Aug 3, 2016

    @sandyarmstrong
    Member
  3. jrieken commented on Aug 4, 2016

    @jrieken
    Contributor

    Sandy Armstrong (@sandyarmstrong) which is very bad suggestion since there is no guarantee from our side (1) if that file will always exist at the location, (2) what class names etc we are going to use, (3) how our build pipeline inlines, rewrites icons, and (4) that the app signing will eventually think about that.

    Everyone is always invited to help out (hello PRs) and it will be a lot more rewarding than a hack like that.

  4. sandyarmstrong commented on Aug 4, 2016

    @sandyarmstrong
    Member

    Johannes Rieken (@jrieken) in retrospect, I was thinking from the context of a consumer of monaco-editor, not a VS Code extension author. You're absolutely right.

  5. jrieken commented on Aug 4, 2016

    @jrieken
    Contributor

    Agreed - for the editor it's a slightly different game.

  6. added
    *as-designedDescribed behavior is as designed
    and removed
    feature-requestRequest for new features or functionality
    on Apr 11, 2017
  7. jrieken commented on Apr 11, 2017

    @jrieken
    Contributor

    For the sake of making it easier to write and share language servers, esp wrt the language service protocol we will stick to a pre-defined set of icons and kinds.

  8. locked and limited conversation to collaborators on Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

*as-designedDescribed behavior is as designedapi

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions