Skip to content

TypeScript shows duplicated suggestions聽#59437

Closed
Closed
TypeScript shows duplicated suggestions#59437
Assignees
mjbvz
Labels
bugIssue identified by VS Code Team member as probable bugjavascriptJavaScript support issuesupstreamIssue identified as 'upstream' component related (exists outside of VS Code)

Description

@jrieken
Johannes Rieken (jrieken)
opened on Sep 26, 2018
  • have the snippet below
  • trigger intellisense inside the toString-method
  • 馃悰 toString appears twice, one insert this.toString, the other just toString
  • the label or details should outline the difference

screenshot 2018-09-26 at 09 33 00

class FooClass {

    field = 1234;
    readonly fold = true


    toString(): void {
        
        
    }
}

Activity

  1. Johannes Rieken (jrieken)
    assigned
    Matt Bierner (mjbvz)
    on Sep 26, 2018

  2. songleilei999 commented on Sep 26, 2018

    @songleilei999
    songleilei999
    on Sep 26, 2018 路 Hidden as spam

  3. mjbvz commented on Sep 26, 2018

    @mjbvz
    Matt Bierner (mjbvz)
    on Sep 26, 2018
    Contributor

    The second suggestion (the one without the this.) is for the DOM window object's toString method. You can reference toString as a global function in browsers contexts

  4. Matt Bierner (mjbvz)
    closed this as completedon Sep 26, 2018
  5. Matt Bierner (mjbvz)
    added
    javascriptJavaScript support issues
    *as-designedDescribed behavior is as designed
    and removed
    *as-designedDescribed behavior is as designed
    on Sep 26, 2018
  6. Matt Bierner (mjbvz)
    reopened this on Sep 26, 2018

  7. mjbvz commented on Sep 26, 2018

    @mjbvz
    Matt Bierner (mjbvz)
    on Sep 26, 2018
    Contributor

    Reopen as your point about displaying these better still stands

  8. Matt Bierner (mjbvz)
    added
    bugIssue identified by VS Code Team member as probable bug
    on Sep 26, 2018

  9. mjbvz commented on Oct 1, 2018

    @mjbvz
    Matt Bierner (mjbvz)
    on Oct 1, 2018
    Contributor

    Opened microsoft/TypeScript#27487 to track this upstream

  10. Matt Bierner (mjbvz)
    closed this as completedon Oct 1, 2018
  11. Matt Bierner (mjbvz)
    added
    upstreamIssue identified as 'upstream' component related (exists outside of VS Code)
    on Oct 1, 2018
  12. vscodebot
    locked and limited conversation to collaborators on Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugjavascriptJavaScript support issuesupstreamIssue identified as 'upstream' component related (exists outside of VS Code)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions