upgrade to vue 2, veux 2 and vue-router 2 - #1
Merged
Conversation
|
waiting for it 👍 |
misterGF
reviewed
Oct 29, 2016
misterGF
left a comment
misterGF
left a comment
Owner
There was a problem hiding this comment.
Great stuff thanks! Hoping to prep this for approval in the coming days.
|
Nice job on update to vue 2! One thing I noticed is if you click repeatedly on the hamburger while on the dashboard, the content will stretch and stretch some more. |
Owner
|
nice find. It's been fixed in the latest commit. |
Contributor
|
Opening https://copilot.mistergf.io/ in Firefox 45.4.0 (the current ESR release from 2016-09-26) routing does not work, the path is actually requested from the server. So when pressing on "Tables" it gets a "Page not found". Is this a known problem with vue-router 2? (BTW. Where should questions, problem reports and request for copilot logged?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.