Skip to content

Add meta for header - #12

Merged
misterGF merged 1 commit into
misterGF:masterfrom
ChangJoo-Park:master
Feb 9, 2017
Merged

Add meta for header#12
misterGF merged 1 commit into
misterGF:masterfrom
ChangJoo-Park:master

Conversation

@ChangJoo-Park

Copy link
Copy Markdown
Contributor

No description provided.

@bernhardreiter

Copy link
Copy Markdown
Contributor

Hi, briefly reading over the change, can you describe what it does?

@ChangJoo-Park

Copy link
Copy Markdown
Contributor Author

@bernhardreiter Sorry I forgot to add description.

It can be using metadata in router.js https://github.com/misterGF/CoPilot/blob/master/src/routes.js#L28

to

@bernhardreiter

Copy link
Copy Markdown
Contributor

@ChangJoo-Park , ah now I see vue-router switched from "custom fields" (v1.0) to "meta field" (v2). And ./src/components/Dash.vue: <small>{{ $route.meta.description }}</small> already uses it. So good addition.

@bernhardreiter bernhardreiter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completes the vue-router update to Vue2. Will display the summary in the heading for the subpage. (I've applied and run it with master.)

@misterGF

misterGF commented Feb 9, 2017

Copy link
Copy Markdown
Owner

Thanks guys. Will be merging this soon.

@misterGF
misterGF merged commit 6ea2bf7 into misterGF:master Feb 9, 2017
@ChangJoo-Park

Copy link
Copy Markdown
Contributor Author

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants