Shows text of Treeview in collapsed sidebar - #70
Merged
Conversation
In a collapsible list of titles on the sidebar, the list's name (the Treeview title) did not show when the sidebar was collapsed and the title was hovered over
Contributor
Author
|
@misterGF sorry to bother you, is the PR good for now or should I change anything and resubmit? |
misterGF
approved these changes
Apr 18, 2018
Owner
|
Looks great. Just merged this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the collapsible list of links on the sidebar (known as a Treeview), the Treeview header's text did not show in the popup that appears when the sidebar is collapsed and the Treeview's icon is hovered over. This happened because the Treeview's collapse button (
fa-angle-left) somehow interfered with the text that was shown.This error is fixed by setting the Treeview header's text to have a z-index, which places the header's text in front of the collapse button.
It now looks like this:
This PR fixes #69.