Skip to content

Refactors common code into own components - #75

Merged
misterGF merged 8 commits into
misterGF:devfrom
Namoshek:refactor-dash-into-components
Jan 3, 2019
Merged

Refactors common code into own components#75
misterGF merged 8 commits into
misterGF:devfrom
Namoshek:refactor-dash-into-components

Conversation

@Namoshek

@Namoshek Namoshek commented Aug 19, 2018

Copy link
Copy Markdown
Contributor

This PR refactors some of the existing component templates into sub-components. This is especially true for the Dash and Dashboard components.

Besides the refactoring, I also made following changes:

  • added an actual user menu which opens when the username in the top right corner is clicked
  • made the messages in the top bar render from the storage and removed the margin on the left side of each message where normally the users avatar would be
  • put the alert box on the dashboard into a <div class="col-xs-12"></div> for nicer looks
  • removed some unused variables (e.g. faker variables in Dash.vue)
  • replaced multiple props of Sidebar.vue with one single user prop (as the same is used for the DashHeader.vue now)
  • replaced the simple notifications menu with a more complex but nice view that has two tabs, one for old notifications and one for new ones. The new menu also has a button to mark all new notifications as read, etc. I developed it for a working application and use it in production but with some different capabilities (e.g. infinite-scrolling for old notifications).
    notifications-menu

Hopefully, I did not forget to mention anything.

@misterGF

Copy link
Copy Markdown
Owner

Thanks for the PR. Please give me a few days to test it out.

@misterGF

Copy link
Copy Markdown
Owner

This looks great @Namoshek! One thing that I ask if that you get rid of the scss css in some of the new pages.

Most of our windows users have been having issues with the node-saas package and I decided to remove it as a devdependency in the base project.

My latest commit removes it from package.json and the Dash.vue page.
This is a good conversion tool- https://www.sassmeister.com/.

Please also push to dev branch. Thanks!

@Namoshek
Namoshek changed the base branch from master to dev August 31, 2018 20:44
@Namoshek

Copy link
Copy Markdown
Contributor Author

Thanks for having a look at it @misterGF! I added the changes you requested and rebased on branch dev.

@misterGF
misterGF merged commit 84c5135 into misterGF:dev Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants