Refactors common code into own components - #75
Merged
Conversation
Owner
|
Thanks for the PR. Please give me a few days to test it out. |
Owner
|
This looks great @Namoshek! One thing that I ask if that you get rid of the scss css in some of the new pages. Most of our windows users have been having issues with the node-saas package and I decided to remove it as a devdependency in the base project. My latest commit removes it from package.json and the Dash.vue page. Please also push to dev branch. Thanks! |
the menu has a tab for old and a tab for new notifications
Contributor
Author
|
Thanks for having a look at it @misterGF! I added the changes you requested and rebased on branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors some of the existing component templates into sub-components. This is especially true for the
DashandDashboardcomponents.Besides the refactoring, I also made following changes:
<div class="col-xs-12"></div>for nicer looksDash.vue)propsofSidebar.vuewith one singleuserprop (as the same is used for theDashHeader.vuenow)Hopefully, I did not forget to mention anything.