Skip to content

Post-deploy housekeeping: build script order, source maps, ogimage.xcf, old static/ tree #488

Open

Description

@stevejalim

Small things noticed while building the deploy pipeline (#480). None is urgent; each is independent, so split this up if that is easier.

  • npm run build orders build:app before build:css. build is npm-run-all build:*, which runs alphabetically, so the Vite build runs before the Stylus compile it depends on. It only works today because both CI and the deploy workflow run npm run build:css as a separate step first. Make build self-sufficient (for example build:1-css, build:2-app, build:3-version.json, or an explicit run-s), then drop the separate step from ci.yml and deploy.yml.
  • Source maps ship to the public bucket. vite.config.mjs sets build.sourcemap: true so npm run size can inspect the bundle, which means roughly 3 MB of .map files are uploaded on every deploy. Decide whether that is wanted. If not, generate maps only for the size command (for example via an env var) and leave the production build without them.
  • public/img/ogimage.xcf is deployed. It is a GIMP source file and gets copied into build/ and uploaded with everything else. Move it out of public/ (or into docs/) so only the rendered PNG ships.
  • Old create-react-app static/ tree in the prod bucket. The May 2025 hand upload left static/js/* and friends in gs://moz-fx-data-static-websit-8565-ensemble. The Vite build uses assets/ instead, so the old tree is dead weight. Once a prod deploy has succeeded and the CDN has moved on, delete static/ from the bucket by hand (never with a root-level rsync --delete; datasets/ shares the bucket). See docs/architecture/deploy.md.

Refs WT-1916.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Fields

Priority

None yet

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions