You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Transfer flakey5/node-with-r2-poc to nodejs/dist-worker #820
+1 to moving repo over. I think it might need a CONTRIBUTING.md and not sure about CODE_OF_CONDUCT.md as it might be inherited from some higher level config.
The concept (and perhaps implementation) should probably be reviewed by the Build WG if it hasn't already. (It looks like none of the champions mentioned in Cloudflare R2 Workers build#3461 are Build WG members.)
The proposed repository name is way too generic in my opinion. It should accurately describe what the exact purpose of the repository is.
was this discussed on the last Build Meeting? Shouldn't this be TSC Agenda?
There wasn't a meeting yet, and I do not see a reason to get the TSC involved just yet - everything is pretty agreed and straightforward
The concept (and perhaps implementation) should probably be reviewed by the Build WG if it hasn't already. (It looks like none of the champions mentioned in nodejs/build#3461 are Build WG members.)
I reviewed this, and I am happy to be added as a champion as well
changed the title [-]Transfer flakey5/node-with-r2-poc to nodejs/cloudflare-workers[/-][+]Transfer flakey5/node-with-r2-poc to nodejs/dist-worker[/+]on Sep 7, 2023
Activity
MoLow commentedon Aug 19, 2023
+1. adding the to build adgenda
mhdawson commentedon Aug 23, 2023
+1 to moving repo over. I think it might need a CONTRIBUTING.md and not sure about CODE_OF_CONDUCT.md as it might be inherited from some higher level config.
flakey5 commentedon Aug 23, 2023
I think both of those are inherited from https://github.com/nodejs/.github?
mhdawson commentedon Aug 24, 2023
@flakey5 thanks for confirming
ovflowd commentedon Aug 31, 2023
@MoLow was this discussed on the last Build Meeting? Shouldn't this be TSC Agenda?
tniessen commentedon Sep 1, 2023
Two thoughts:
MoLow commentedon Sep 1, 2023
There wasn't a meeting yet, and I do not see a reason to get the TSC involved just yet - everything is pretty agreed and straightforward
I reviewed this, and I am happy to be added as a champion as well
flakey5 commentedon Sep 1, 2023
How about nodejs/dist-worker?
[-]Transfer flakey5/node-with-r2-poc to nodejs/cloudflare-workers[/-][+]Transfer flakey5/node-with-r2-poc to nodejs/dist-worker[/+]Trott commentedon Sep 13, 2023
Since @ovflowd wants to add @flakey5 to the
@nodejs/web-infrateam, that will take care of the org invitation. (I'll add them right now.)flakey5 commentedon Sep 13, 2023
Thanks!
MoLow commentedon Sep 26, 2023
Discussed this in the last Build WG meeting. going to take care of this
MoLow commentedon Sep 26, 2023
transferred to https://github.com/nodejs/release-cloudflare-worker
will continue working on it at nodejs/build#3461