Repository navigation
Suggestion: have branch-diff check commit comments for PR metadata #16
Description
We get problems like this: nodejs/node@75318e4#commitcomment-24788304 all the time. The solution we have is to put the PR-URL (or other relevant metadata) in a comment on the commit.
If branch-diff could check this it would alleviate the problem for LTS maintainers.
I was going to have a look at implementing this but never got around to it. Thought I'd put this here in case anyone else has the time and inclination.
cc/ @MylesBorins @rvagg
Activity
MylesBorins commentedon Oct 9, 2017
@gibfahn I've thought about this a number of times myself.
I believe this would need to be implemented in commit-stream, and branch-diff would inherit the change
rvagg commentedon Oct 16, 2017
We could do it at any point in the chain I think. Given that commit-stream is a fairly dumb stream that doesn't do network at the moment it might make most sense to do it in changelog-maker where we do a lot of GitHub fetching already. When a commit comes in from commit-stream without a
prUrlwe could call out to the comments on the commit. Unfortunately I don't have any existing libraries to get commit comments, I've never needed that before. I've got issues and pulls. It looks like the API for this hangs off "Repositories" so it could go here pretty simply I think (the comments & pagination code is shared across all of these libraries and should be straightforward to extend for this)./cc @ralphtheninja FYI
ralphtheninja commentedon Oct 17, 2017
Added https://github.com/rvagg/ghrepos/tree/commits-and-comments#getcommitcommentsauth-org-repo-sha1-options-callback
gibfahn commentedon Jan 3, 2018
@ralphtheninja @rvagg what's the status of this? Anything I could do to help out?
ralphtheninja commentedon Jan 3, 2018
@gibfahn
ghreposhas support for retrieving commit comments so I'm guessing it would be a matter of tweakingchangelog-maker.MylesBorins commentedon Feb 10, 2018
@gibfahn should this move to branch-diff?
gibfahn commentedon Feb 19, 2018
Sounds like it needs coordination across multiple repos, so I'd prefer to leave this open for now.