Skip to content

[request] cmake build job #1003

Closed
Closed

Description

@bnoordhuis

I'd like to start testing my cmake branch: https://github.com/bnoordhuis/io.js/tree/cmake

To that end, it would be helpful to have a node-test-commit-like job with the difference that it should run ./configure --cmake=/path/to/cmake.

Cmake version: I'm testing with 3.9 but anything >= 3.6 should be good enough.

Platform matrix: bigger is better but fast - especially in the initial phase - I'd appreciate the most. Linux, Windows, MacOS to start out with?

cc @gibfahn

Activity

  1. self-assigned this
    on Nov 21, 2017
  2. bnoordhuis commented on Nov 27, 2017

    @bnoordhuis
    MemberAuthor

    @gibfahn Just wondering if you had time to look at this. No pressure, on my desk by 1600 is fine.

  3. gibfahn commented on Nov 27, 2017

    @gibfahn
    Member

    I'll trade you it for a rebased/revived nodejs/node#12231

  4. bnoordhuis commented on Nov 27, 2017

    @bnoordhuis
    MemberAuthor

    You drive a hard bargain... I'll see what I can do.

  5. bnoordhuis commented on Dec 22, 2017

    @bnoordhuis
    MemberAuthor

    @gibfahn Any news?

  6. rvagg commented on Dec 28, 2017

    @rvagg
    Member

    @bnoordhuis I could quickly spin one up for you using Docker but you'd only get Linux then. We do this with Alpine and the miscellaneous quirky build types in node-test-commit-linux-linked by just adding and deploying Dockerfiles. We could get >1 distro covered it if helps. Would that be good enough to get started or is there not much point unless you have the full suite of OSs covered?

  7. rvagg commented on Dec 28, 2017

    @rvagg
    Member

    On second thought, it's probably not an ideal setup to throw it into a Docker container. Maybe we just give you a dedicated Jenkins job with write permissions for you so you can attach arbitrary nodes to and script them up as necessary to test it out.

  8. bnoordhuis commented on Dec 28, 2017

    @bnoordhuis
    MemberAuthor

    Yes, please. I'm well-stocked on the Linux and MacOS front but being able to test Windows, AIX, etc. would be a big boon.

  9. gibfahn commented on Jan 3, 2018

    @gibfahn
    Member

    Okay, I've done the first part of this, which is changing node-test-commit to allow you to pass a custom set of CONFIG_FLAGS.

    You can call it like this: https://ci.nodejs.org/job/node-test-commit/15212/

    image

    Now I just have to work out how to get cmake installed and in the path on all the machines (including AIX...). I guess it's a good chance to test the ansible scripts...

  10. gibfahn commented on Jan 3, 2018

    @gibfahn
    Member

    BTW @bnoordhuis , it'd be nice if when cmake wasn't in the path the error specifically mentioned which file wasn't found (in this case cmake).

    Traceback (most recent call last):
      File "./configure", line 1562, in <module>
        configure_cmake(output)
      File "./configure", line 1439, in configure_cmake
        sys.exit(subprocess.Popen(cmake_args, cwd='out.cmake').wait())
      File "/usr/lib64/python2.7/subprocess.py", line 711, in __init__
        errread, errwrite)
      File "/usr/lib64/python2.7/subprocess.py", line 1327, in _execute_child
        raise child_exception
    OSError: [Errno 2] No such file or directory
    make: *** [build-ci] Error 1
    
  11. maclover7 commented on May 24, 2018

    @maclover7
    Contributor

    ping @bnoordhuis @gibfahn -- is this still needed?

  12. bnoordhuis commented on May 25, 2018

    @bnoordhuis
    MemberAuthor

    Yes.

  13. assigned and unassigned on Jun 15, 2018
  14. deleted a comment from github-actions on Mar 11, 2020
  15. bnoordhuis commented on Mar 11, 2020

    @bnoordhuis
    MemberAuthor

    I can get by with GH Actions for now so I'll close this out, cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions