Skip to content

Don't test ppcbe for node >7 #1068

Closed
Closed

Description

@gibfahn

Should we stop running CI for Node > 7.x? We have this code in our release job:

if [[ $ARCH == ppc64 && ${NODE_MAJOR_VERSION} -gt 7 ]]; then
  echo "Not building $disttype on PPC Big Endian slave $NODE_NAME as not supported for v8.x and later"
  exit 0
fi

Activity

  1. gibfahn commented on Jan 3, 2018

    @gibfahn
    MemberAuthor

    @mhdawson if we already discussed this somewhere else and I forgot let me know.

  2. mhdawson commented on Jan 3, 2018

    @mhdawson
    Member

    I've been doing it in stages without a rush.

    1. remove from main download page wait to see if we get any complaints
    2. remove generation of builds in releases, wait to see if we get any complaints..

    next is remove from testing for >= 8 (not >- 7.x as you say above). I'm in no rush, but we probably have had enough time pass that stopping testing for >=8 is ok.

  3. gibfahn commented on Jan 3, 2018

    @gibfahn
    MemberAuthor

    not >- 7.x as you say above

    Edited.

  4. maclover7 commented on May 22, 2018

    @maclover7
    Contributor

    @gibfahn @mhdawson Has node-test-commit been updated with these changes?

  5. mhdawson commented on May 23, 2018

    @mhdawson
    Member

    Yes this is done closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions