Skip to content

Offboard inactive members #2390

Closed
Closed

Description

@AshCripps

Follow on from #2357 and #2358

Checklist for the offboarding of the following members:

@LucaLanziani (build)
@maclover7 (build and jenkins)
@addaleax (build)
@gireeshpunathil (build)

Thank you all for your contributions and you will be welcomed back if you wish to return!

Offboarding issue checklist

  • Remove their GPG key from test group in nodejs-private/secrets
  • Remove their GPG key from release group in nodejs-private/secrets
  • Remove their GPG key from infra group in nodejs-private/secrets
  • Remove their GPG key from infra-macstadium group in nodejs-private/secrets
  • Remove their GPG key from github-bot group in nodejs-private/secrets
  • Remove them from build teams they are a member of:
    • nodejs/build
    • nodejs/build-release
    • nodejs/build-infra
    • nodejs/jenkins-admins
    • nodejs/jenkins-release-admins
    • nodejs-private/build
  • PR changes to README.md to move the member to emeritus status
  • Run ncu-team sync README.md to validate the user has been removed from the build teams
  • Remove them from the nodejs/email alias

Activity

  1. AshCripps commented on Jul 29, 2020

    @AshCripps
    MemberAuthor

    @nodejs/build anyone had any experience as to when I tried to clean up these keys from secrets it deleted the inventory.yml file as well? (I did also try to clean up an old keys of georges that was still left in the folder)

  2. jbergstroem commented on Jul 29, 2020

    @jbergstroem
    Member

    @AshCripps haven't seen that. Did you use dotgpg rm to remove the keys?

  3. AshCripps commented on Jul 29, 2020

    @AshCripps
    MemberAuthor

    yep I did get some gem errors though -

    /Library/Ruby/Gems/2.3.0/gems/gpgme-2.0.19/lib/gpgme/ctx.rb:385:in `import_keys': Too many open files (GPGME::Error)
    
  4. rvagg commented on Jul 30, 2020

    @rvagg
    Member

    Silly low open files limit on macos, you need to increase the limit, ulimit -n 10000 or something. There's a more advanced command that sets it permanently but I don't have that at hand. Check out a clean copy of the repo, lift the limit in your current shell and run it again.

  5. AshCripps commented on Aug 3, 2020

    @AshCripps
    MemberAuthor

    Removed from the secrets repo - all except luca's key got not a valid gpg key for that one.
    Will need someone to remove @maclover7's key from githubbot secrets as I dont have access and then someone to remove the above from the github teams as im not a maintainer.

  6. rvagg commented on Aug 4, 2020

    @rvagg
    Member

    done

  7. AshCripps commented on Oct 6, 2020

    @AshCripps
    MemberAuthor

    Can the one of the members of build with TSC overlord powers remove the poeple at the top of the issue from the respective teams please? @mhdawson @Trott @mmarchini

  8. mhdawson commented on Oct 6, 2020

    @mhdawson
    Member

    @AshCripps done, does not look like there is a nodejs/build-release team, was that the right name?

  9. AshCripps commented on Oct 6, 2020

    @AshCripps
    MemberAuthor

    build-release is referring to secrets team I believe

  10. mhdawson commented on Oct 7, 2020

    @mhdawson
    Member

    @AshCripps there is no team specifically related to secrets but those in the nodejs-private/build team have access to the secrets repo. I've remove the inactive members from that team so I think we should be good.

  11. mmarchini commented on Oct 8, 2020

    @mmarchini
    Contributor

    Is build-release referring to the private keys instead of a team?

  12. AshCripps commented on Oct 8, 2020

    @AshCripps
    MemberAuthor

    Is build-release referring to the private keys instead of a team?

    sorry yes its referring to those you have access to the keys - theres no "team" as such cause there doesnt need to be.

  13. AshCripps commented on Oct 8, 2020

    @AshCripps
    MemberAuthor

    Closing as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions