You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@nodejs/build anyone had any experience as to when I tried to clean up these keys from secrets it deleted the inventory.yml file as well? (I did also try to clean up an old keys of georges that was still left in the folder)
Silly low open files limit on macos, you need to increase the limit, ulimit -n 10000 or something. There's a more advanced command that sets it permanently but I don't have that at hand. Check out a clean copy of the repo, lift the limit in your current shell and run it again.
Removed from the secrets repo - all except luca's key got not a valid gpg key for that one.
Will need someone to remove @maclover7's key from githubbot secrets as I dont have access and then someone to remove the above from the github teams as im not a maintainer.
Can the one of the members of build with TSC overlord powers remove the poeple at the top of the issue from the respective teams please? @mhdawson@Trott@mmarchini
@AshCripps there is no team specifically related to secrets but those in the nodejs-private/build team have access to the secrets repo. I've remove the inactive members from that team so I think we should be good.
Activity
AshCripps commentedon Jul 29, 2020
@nodejs/build anyone had any experience as to when I tried to clean up these keys from secrets it deleted the inventory.yml file as well? (I did also try to clean up an old keys of georges that was still left in the folder)
jbergstroem commentedon Jul 29, 2020
@AshCripps haven't seen that. Did you use
dotgpg rmto remove the keys?AshCripps commentedon Jul 29, 2020
yep I did get some gem errors though -
rvagg commentedon Jul 30, 2020
Silly low open files limit on macos, you need to increase the limit,
ulimit -n 10000or something. There's a more advanced command that sets it permanently but I don't have that at hand. Check out a clean copy of the repo, lift the limit in your current shell and run it again.AshCripps commentedon Aug 3, 2020
Removed from the secrets repo - all except luca's key got
not a valid gpg keyfor that one.Will need someone to remove @maclover7's key from githubbot secrets as I dont have access and then someone to remove the above from the github teams as im not a maintainer.
rvagg commentedon Aug 4, 2020
done
AshCripps commentedon Oct 6, 2020
Can the one of the members of build with TSC overlord powers remove the poeple at the top of the issue from the respective teams please? @mhdawson @Trott @mmarchini
mhdawson commentedon Oct 6, 2020
@AshCripps done, does not look like there is a nodejs/build-release team, was that the right name?
AshCripps commentedon Oct 6, 2020
build-release is referring to secrets team I believe
doc: update team members with ncu-team sync
mhdawson commentedon Oct 7, 2020
@AshCripps there is no team specifically related to secrets but those in the
nodejs-private/buildteam have access to the secrets repo. I've remove the inactive members from that team so I think we should be good.mmarchini commentedon Oct 8, 2020
Is build-release referring to the private keys instead of a team?
AshCripps commentedon Oct 8, 2020
sorry yes its referring to those you have access to the keys - theres no "team" as such cause there doesnt need to be.
doc: update team members with ncu-team sync (#2458)
AshCripps commentedon Oct 8, 2020
Closing as complete.
doc: update team members with ncu-team sync (#2458)