You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey 馃憢 as seen in some discussions on Slack, we've noticed a few little changes we can accomplish to improve (assumingly) the situation related to Node.js Website 5XX Errors when serving binaries.
The changes are outlined in the images below, and the red markers demonstrate what fields need to be changed. (The values shown within these images are the desired result).
The changes below are unrelated but meant to fix some broken links since we've moved to Vercel. The image below shows the entries that should be removed from the Vercel Origin Rule.
The images below are new Redirect Rules that should be created:
(Added the build-agenda label so it gets discussed at a meeting in case this stalls or otherwise doesn't get done. Feel free to remove if that's not appropriate. I'm just trying to help Claudio with visibility on this issue.)
If someone has the appropriate access to do this but doesn't want to make more than a small change at a time to caching, perhaps the "don't cache status codes 500 and above" part can be a smaller change that would hopefully have some positive effect?
If someone has the appropriate access to do this but doesn't want to make more than a small change at a time to caching, perhaps the "don't cache status codes 500 and above" part can be a smaller change that would hopefully have some positive effect?
There's a small typo on the image, on the image both are "No cache" but it should be "No cache" and then "No store"
@ovflowd I tried doing the small change today, but unfortunately Cloudflare tells me status_code ranges should not overlap (Code: 20110) so the fix for the typo does not seem to be correct.
changed bypass cache for vercel-paths from (http.host eq "nodejs.org" and not http.request.uri.path matches "^/(dist|download|docs|api|documentation|metrics)") to (http.host eq "nodejs.org" and not http.request.uri.path matches "^/(dist|download|docs|api|metrics)")
changed cache non-vercel paths from (http.host eq "nodejs.org" and http.request.uri.path matches "^/(dist|download|docs|api|documentation|metrics)") or (http.host eq "origin.nodejs.org") to (http.host eq "nodejs.org" and http.request.uri.path matches "^/(dist|download|docs|api|metrics)") or (http.host eq "origin.nodejs.org")
adding no store for > 500 status code has already been taken care of by @mhdawson
Activity
Trott commentedon Aug 24, 2023
@nodejs/build
Trott commentedon Aug 24, 2023
(Added the
build-agendalabel so it gets discussed at a meeting in case this stalls or otherwise doesn't get done. Feel free to remove if that's not appropriate. I'm just trying to help Claudio with visibility on this issue.)Trott commentedon Sep 21, 2023
If someone has the appropriate access to do this but doesn't want to make more than a small change at a time to caching, perhaps the "don't cache status codes 500 and above" part can be a smaller change that would hopefully have some positive effect?
ovflowd commentedon Sep 21, 2023
There's a small typo on the image, on the image both are "No cache" but it should be "No cache" and then "No store"
mhdawson commentedon Sep 25, 2023
@ovflowd I tried doing the small change today, but unfortunately Cloudflare tells me
status_code ranges should not overlap (Code: 20110)so thefixfor the typo does not seem to be correct.mhdawson commentedon Sep 25, 2023
I set it to be one entry which is just the
No storeas from some reading I believe that was what was needed.ovflowd commentedon Sep 25, 2023
I guess tat's fine! (cc @MattIPv4) (Is no store preferrable to no cache?)
MattIPv4 commentedon Sep 25, 2023
馃憤 No store makes sense here, it is a more aggressive no cache aiui.
ovflowd commentedon Sep 26, 2023
@targos would you have time for making the other changes? (Except the one that @mhdawson already did?)
MoLow commentedon Sep 26, 2023
I'l take a look at the other changes. CC @nodejs/build
MoLow commentedon Sep 26, 2023
bypass cache for vercel-pathsfrom(http.host eq "nodejs.org" and not http.request.uri.path matches "^/(dist|download|docs|api|documentation|metrics)")to(http.host eq "nodejs.org" and not http.request.uri.path matches "^/(dist|download|docs|api|metrics)")cache non-vercel pathsfrom(http.host eq "nodejs.org" and http.request.uri.path matches "^/(dist|download|docs|api|documentation|metrics)") or (http.host eq "origin.nodejs.org")to(http.host eq "nodejs.org" and http.request.uri.path matches "^/(dist|download|docs|api|metrics)") or (http.host eq "origin.nodejs.org")thanks @ovflowd
ovflowd commentedon Sep 26, 2023
Thank you so much, @MoLow !!