Skip to content

expected_assets checks should validate HTML docs were generated #4506

Open

Description

@richardlau

See nodejs/node#66571.

Presently our expected_assets checks during release promotion are only checking a few things under docs, e.g. for v26.x:

docs/
docs/apilinks.json
docs/api/
docs/llms.txt
docs/node-config-schema.json

So we did not catch that no HTML files were generated.

I don't know the historical reason for only checking the top level docs (speculating here, but maybe time and/or the annoyance of listing out all 200+ files in each expected asset list?), but it does appear to be deliberate, e.g.

// equivalent to `find -maxdepth 2`
async function lsDepth2 (dir, isStaging) {

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions