Repository navigation
Install of Rscript on new benchmarking machines #821
Description
Hello,
Now that two machines have been donated for benchmarking, I've merged a script that was written a while ago for evaluating the impact of a PR on a subset of benchmarks. I've started putting something together in jenkins, however the script makes use of Rscript which will need installing on the two new servers.
The build issue for the machine was #791 and the task in benchmarking was nodejs/benchmarking#58
There's instructions in the benchmarking guide here: https://github.com/nodejs/node/blob/master/doc/guides/writing-and-running-benchmarks.md
It seems the new machines run ubuntu, so I think this should work:
Add "deb https://cran.us.r-project.org/bin/linux/ubuntu xenial/" to /etc/apt/sources.list
sudo apt-get update
sudo apt-get install r-base r-base-dev
Then install two required packages through the R repl
R
install.packages("ggplot2", repo="http://cran.us.r-project.org")
install.packages("plyr", repo="http://cran.us.r-project.org")
Thanks!
@mhdawson fyi
Activity
AndreasMadsen commentedon Aug 4, 2017
I suppose
ggplot2could be made optional since we are not making any figures. But right now I think it is a requirement.gareth-ellis commentedon Aug 9, 2017
Anyone in @nodejs/build who could take care of this? (I am assuming I'm opening this in the right place....please let me know if I've opened this in the wrong place... :) )
rvagg commentedon Aug 9, 2017
OK, I've done this manually on both servers, but this really needs to be automated in our ansible scripts (see ansible directory) so if someone could try and take care of that it'd be greatly appreciated. This work seems pretty good and would cover all of these tasks fairly simply I think: https://github.com/Oefenweb/ansible-r, otherwise it could be used as a base, or the following could just be hardcoded as shell executions:
Crossing fingers that this is all that's required. There's a hefty amount of packages in there!
refack commentedon Aug 9, 2017
I've asked a friend who is an R maven to port
compare.Rto node, but it'll take some time + the PR cycle.AndreasMadsen commentedon Aug 9, 2017
@refack have some concerns about that. There should be an open pull request about it, where I've commented on some of the issues.
I'm on mobile so I can't find it for you, sorry.
refack commentedon Aug 9, 2017
I'll look it up.
refack commentedon Aug 9, 2017
nodejs/node#7094?Found it nodejs/node#12585
mhdawson commentedon Aug 14, 2017
I was out on holiday. @rvagg was the only option to install on the machine itself. It at all possible I would have preferred that the job do the install to a temporary directory but I understand that is not always possible.
refack commentedon Oct 14, 2017
Has this been resolved?
ansible: add rscript/wrk for benchmarking machines