Repository navigation
v21.x failing modules #1033
Description
The last 3 runs failed on Node.js 21. I've run against v21.x just to confirm it's nothing related to the v21.3.0 proposal
- v21.3.0 proposal (1) https://ci.nodejs.org/job/citgm-smoker/3350/
- v21.3.0 proposal (2) https://ci.nodejs.org/job/citgm-smoker/3351/
- v21.x https://ci.nodejs.org/job/citgm-smoker/3352/
Modules:
citgm.jest-v29.7.0 #1032
citgm.ember-cli-v5.4.1 - @stefanpenner, @rwjblue, @Turbo87, @kellyselden
citgm.yeoman-generator-v7.1.1 - @SBoudrias, @sindresorhus
citgm.nan-v2.18.0 - @nodejs/addon-api
citgm.q-v1.5.1 - @kriskowal
Activity
ljharb commentedon Nov 30, 2023
i believe maxogden → @max-mapper
arcanis commentedon Nov 30, 2023
How can we check the logs? The
@yarnpkg/clilogs seem unrelated to Yarn (ConnectTimeoutError: Connect Timeout Error), but perhaps I'm looking at the wrong place.RafaelGSS commentedon Nov 30, 2023
@arcanis some of them might be related to the machine, yeah. I just want to make sure these timeouts aren't flaky on
yarnpkg/clibut something with our machineThe ci.nodejs.org links are the ones with logs.
novemberborn commentedon Nov 30, 2023
AVA's failure is (most likely) a known issue, fixed in main but not yet released.
mourner commentedon Dec 3, 2023
I tried looking into what might be the problem in
binary-split, but it seems to work fine with Node v21.3. The logs for the failure above also saysConnectTimeoutError: Connect Timeout Error, so perhaps it's just a flaky test and not something that needs fixing?RafaelGSS commentedon Dec 3, 2023
Timeout errors are usually machine issues since we run tests in parallel and the CPU can get stale causing timeouts. If this persists we can reduce/remove the concurrency - but it might affect the time elapsed of CITGM, which is undesirable.
lpinca commentedon Dec 3, 2023
The ws failure is the same and on the same platform for all runs. On macOS, that test also fails on GHA sometimes. I would prefer not to do it, but I think I can skip it on macOS.
RafaelGSS commentedon Dec 4, 2023
I've just removed for the issue description the modules where the authors/maintainers confirmed the issues aren't related to the package itself. Thank you!
I'll wait maintainers' input for the other ones.
lib: skip "q" on Node.js >= 21
lib: skip "yeoman-generator" on Node.js >= 21
lib: skip "ember-cli" on Node.js >= 21
RafaelGSS commentedon Dec 12, 2023
I've read all the lists again and removed the ones failing with timeout, which tends to be a machine issue and I've created a PR to skip the non-machine-related failing on Node.js 21. #1035
lib: skip flaky modules on v21 (#1035)
RafaelGSS commentedon Jan 15, 2024
Last v21.x run:
Failures:
RafaelGSS commentedon May 22, 2024
Closing in favour of #1060