Should doc-kit import node-core/website-i18n directly #1119

Activity

1. bmuenzenmeyer commented on Sep 30, 2026

   

   bmuenzenmeyer

   on Sep 30, 2026

   Contributor

   More actions

   good question. the blame on that TODO is a year old, and pre-dates our more recent effort to decouple the packages. I know I already approved nodejs/nodejs.org#9180 but similar to ui components, perhaps that is simply a default
2. avivkeller commented on Sep 30, 2026

   

   avivkeller

   on Sep 30, 2026

   Member

   More actions

   Not sure, I know we aren't translating these docs, fwiw

   👍React with 👍1Reacted by Brian Muenzenmeyer
3. moshams272 commented on Sep 30, 2026

   

   moshams272

   on Sep 30, 2026

   Last edited by moshams272

   ContributorAuthor

   More actions

   good question. the blame on that TODO is a year old, and pre-dates our more recent effort to decouple the packages. I know I already approved nodejs/nodejs.org#9180 but similar to ui components, perhaps that is simply a default

   We can update the generator to accept these labels through getConfig('jsx-ast'), using the English strings as fallback defaults.

   BTW, I converted that PR to draft, so we can decide here what we will do.

   Not sure, I know we aren't translating these docs, fwiw

   Yeah, you're right. However, the main goal here is just to avoid having these strings hardcoded in doc-kit, so we can have a "single source of truth" (from website-i18n).

   WDUT, guys? 👀