Skip to content

Outdated Docker image peterdavehello/shfmt:2.6.3 in shfmt.yml #2555

Closed
Feature
#2583
Closed
Outdated Docker image peterdavehello/shfmt:2.6.3 in shfmt.yml#2555
Feature
#2583
Assignees
PeterDaveHello
Labels
ciCI (Continuous Integration) workflows

Description

@MikeMcC399
MikeMcC399
opened on Jul 7, 2026

Current status

.github/workflows/shfmt.yml uses the Docker image

peterdavehello/shfmt:2.6.3

published by @PeterDaveHello in Jan 2019.

Suggestion

Check if the version of peterdavehello/shfmt used in .github/workflows/shfmt.yml should be updated to a later version.

Also consider the comment in https://hub.docker.com/r/peterdavehello/shfmt

Please note that I originally built this Docker image because that there wasn't an official one, but now there it is, and it also use the Dockerfile in this repository as the reference to create the official one, as you can see mvdan/sh#68, this repository might not be actively maintained.

Check if the Docker image https://hub.docker.com/r/mvdan/shfmt/ could be a replacement.

Activity

  1. MikeMcC399
    added the
    Feature
    issue type on Jul 7, 2026
  2. MikeMcC399
    added
    ciCI (Continuous Integration) workflows
    on Jul 7, 2026

  3. MikeMcC399 commented on Jul 13, 2026

    @MikeMcC399
    MikeMcC399
    on Jul 13, 2026
    ContributorAuthor

    @PeterDaveHello

    Would you like to take a look at resolving this issue, since the image is in your name?

  4. PeterDaveHello commented on Jul 14, 2026

    @PeterDaveHello
    PeterDaveHello
    on Jul 14, 2026
    Member

    Sure, I can take a look.

  5. PeterDaveHello
    self-assigned this
    on Jul 14, 2026

  6. MikeMcC399 commented on Jul 19, 2026

    @MikeMcC399
    MikeMcC399
    on Jul 19, 2026
    ContributorAuthor

    Another possibility, instead of using a custom Docker image, would be to install and run the Ubuntu package shfmt:

          - run: |
          sudo apt-get update
          sudo apt-get install -y shfmt
      - run: shfmt -sr -i 2 -l -w -ci .

  7. MikeMcC399 commented on Jul 22, 2026

    @MikeMcC399
    MikeMcC399
    on Jul 22, 2026
    ContributorAuthor

    I'm planning to update this together with a resolution for #2571

  8. MikeMcC399 commented on Jul 30, 2026

    @MikeMcC399
    MikeMcC399
    on Jul 30, 2026
    ContributorAuthor

    Submitted as #2583.

    I didn't include it in #2576 because that PR is about using npm packages for formatting, linting and link checking.

    This one is using an Ubuntu package.

  9. nschonni commented on Jul 30, 2026

    @nschonni
    nschonni
    on Jul 30, 2026
    Member

    Interesting, just saw there was an NPM package that they point to https://github.com/un-ts/sh-syntax

  10. MikeMcC399 commented on Jul 30, 2026

    @MikeMcC399
    MikeMcC399
    on Jul 30, 2026
    ContributorAuthor

    Interesting, just saw there was an NPM package that they point to https://github.com/un-ts/sh-syntax

    It doesn't look like it has a CLI. An npm package would be preferable, as it is more cross-platform compatible.

  11. MikeMcC399
    closed this as completedin #2583on Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

ciCI (Continuous Integration) workflows

Type

Feature

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions