Get the location of msbuild.exe #128

Activity

1. cclauss commented on Oct 8, 2021

   

   cclauss

   on Oct 8, 2021

   Contributor

   More actions

   libsodium issues: https://github.com/nodejs/node-gyp/search?q=libsodium&type=issues
2. rvagg

   transferred this issue fromnodejs/node-gypon Oct 11, 2021
3. rvagg commented on Oct 11, 2021

   

   rvagg

   on Oct 11, 2021

   Member

   More actions

   I've moved this issue to gyp-next. @mafintosh, most of the logic you want is inside gyp-next which is a separate repo now and designed to be consumed as a python library. I'm neither a Python, nor a Windows person, and that particular combination of skills is in fairly low supply in the nodejs org, but maybe one of the folks here could point you in the right direction to start sniffing down what you want.

   @nodejs/gyp
4. vweevers commented on Oct 11, 2021

   

   vweevers

   on Oct 11, 2021

   More actions

   I believe the (better) logic is in node-gyp nowadays, since nodejs/node-gyp#1762. So there are a few options:

   1. Use gyp-next's python code: MSVSVersion.py. Not great because you'd then also have to find the path to python, and this method queries the Windows registry which is less bullet-proof.
   2. Use node-gyp's C# script: Find-VisualStudio.cs. This method uses COM objects, same as used by Microsoft's official vswhere
   3. Or from JS, to run that script with powershell and parse its output: require('node-gyp/lib/find-visualstudio.js')(...).
   4. Bundle vswhere.exe
   5. Run node-gyp configure and then extract variables.msbuild_path from build/config.gypi
   6. Add a command to node-gyp to print those variables.

   The last 2 options are the best IMO, because there's no Python, C# or exe to bundle, and it will respect the user's configuration (npm_config_msvs_version and what not).
5. vweevers commented on Oct 11, 2021

   

   vweevers

   on Oct 11, 2021

   More actions

   Sample build/config.gypi:

   # Do not edit. File was generated by node-gyp's "configure" step
   {
     "target_defaults": {
       ...
     },
     "variables": {
       ...
       "msbuild_path": "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Professional\\MSBuild\\Current\\Bin\\MSBuild.exe",
     }
   }
6. cclauss commented on Oct 11, 2021

   

   cclauss

   on Oct 11, 2021

   Contributor

   More actions

   As the "Python guy" working on the gyp project for the past several years, it would be great if this community could wean itself off of the need for Python. It is easier for this community to code and maintain solutions in JavaScript so please continue migrating in that direction.