You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not used to Python and have never worked with typing, so my opinion wouldn't be very informed.
I work with TypeScript though and do like type annotations, so I'm not opposed to that if it makes it easier / safer to develop and if it can be introduced incrementally.
Unfortunately, this is not a choice that one person can make. How do we get the Node.js Technical Steering Commitee to agree to drop support for legacy Python which died 200 days ago.
You don't necessarily need the whole TSC to agree on it. The process is to open a PR dropping Python 2. If we cannot reach consensus (i.e. some collaborator(s) disagree), then the TSC will have to make a decision.
Activity
targos commentedon Jul 15, 2020
I'm not used to Python and have never worked with
typing, so my opinion wouldn't be very informed.I work with TypeScript though and do like type annotations, so I'm not opposed to that if it makes it easier / safer to develop and if it can be introduced incrementally.
ryzokuken commentedon Jul 16, 2020
IIUC, these are both true for this.
cclauss commentedon Jul 16, 2020
I am a huge fan of type hints in Python but they break compatibility with Python 2. If we a green light to drop legacy Python then let's go for it.
ryzokuken commentedon Jul 17, 2020
Personally, I don't see why we should let Python 2 hold us back in 2020?
targos commentedon Jul 17, 2020
As long as Node.js and node-gyp support Python 2 in their main development branches, I am against removing support here.
cclauss commentedon Jul 17, 2020
Unfortunately, this is not a choice that one person can make. How do we get the Node.js Technical Steering Commitee to agree to drop support for legacy Python which died 200 days ago.
targos commentedon Jul 17, 2020
You don't necessarily need the whole TSC to agree on it. The process is to open a PR dropping Python 2. If we cannot reach consensus (i.e. some collaborator(s) disagree), then the TSC will have to make a decision.
ryzokuken commentedon Jul 17, 2020
@targos what does the PR need to do? Since the tooling is already Python 3 compatible, I suppose we're looking at a doc-only PR here.
targos commentedon Jul 17, 2020
Almost doc-only, yes. There's also at least one place where we validate the python version (the
configurefile)cclauss commentedon Jul 17, 2020
Add Python type hints and drop support for Python 2sounds like a nice PR title to me.ryzokuken commentedon Jul 17, 2020
drop support for Python 2in nodejs/node first![-]Add type information[/-][+]Add Python type hints to function signatures[/+][-]Add Python type hints to function signatures[/-][+]Add type hints to Python function signatures[/+]