Skip to content

v2.26.0 broken nan.h line 843 compiler error (missing closing parenthesis) #1012

Open
Open
v2.26.0 broken nan.h line 843 compiler error (missing closing parenthesis)#1012

Description

@danielweck
danielweck
opened on Mar 17, 2026

Line 843:
fcc7b7d

nan/nan.h

Lines 837 to 844 in 49a9e55

#if (V8_MAJOR_VERSION > 14) || \
(V8_MAJOR_VERSION == 14 && V8_MINOR_VERSION > 2) || \
(V8_MAJOR_VERSION == 14 && V8_MINOR_VERSION == 2 && V8_BUILD_NUMBER >= 194)
return object->GetAlignedPointerFromInternalField(
object->SetAlignedPointerInInternalField(
index, value, v8::kEmbedderDataTypeTagDefault
);
# else

Activity

  1. danielweck commented on Mar 17, 2026

    @danielweck
    danielweck
    on Mar 17, 2026
    Author

    The copy-pasta of return object->GetAlignedPointerFromInternalField( went wrong :)
    (ended up in the SETTER in addition to the GETTER)

  2. danielweck commented on Mar 17, 2026

    @danielweck
    danielweck
    on Mar 17, 2026
    Author

    ah, there's an opened PR that fixes this: #1011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions