Support Isolate::RunMicrotasks #914

Activity

1. addaleax commented on May 26, 2021

   

   addaleax

   on May 26, 2021

   Member

   More actions

   @romgrk What exactly are you looking for here? The change you linked is not an API change.
2. romgrk commented on May 26, 2021

   

   romgrk

   on May 26, 2021

   ContributorAuthor

   More actions

   Wdym by not an API change? It was previously Isolate::RunMicrotasks, it's now Isolate::PerformMicrotaskCheckpoint. Something like Nan::RunMicrotasks() would be nice.

   #if V8_MAJOR_VERSION >= 9
       Isolate::GetCurrent()->PerformMicrotaskCheckpoint();
   #else
       Isolate::GetCurrent()->RunMicrotasks();
   #endif
3. addaleax commented on May 26, 2021

   

   addaleax

   on May 26, 2021

   Member

   More actions

   @romgrk Could it be that you’re thinking about a different V8 commit then? Only changes to include/ are relevant for Node.js addons.

   That being said – Node.js addons should generally not run the microtask queue manually, because Node.js itself manages it. Do you have a specific use case in mind?
4. romgrk commented on May 26, 2021

   

   romgrk

   on May 26, 2021

   ContributorAuthor

   More actions

   @romgrk Could it be that you’re thinking about a different V8 commit then? Only changes to include/ are relevant for Node.js addons.

   Ok, not that's the commit I'm thinking about, not sure how you classify what goes in or not but I was under the impression that this was for anything that needs to be specialized for different V8 versions.

   That being said – Node.js addons should generally not run the microtask queue manually, because Node.js itself manages it. Do you have a specific use case in mind?

   I know, but my addon isn't like most of them :| I need to stop nodejs event loop to replace it with GTK's event loop and call uv_run from within it. Very unconventional and has bad implications for how things work, but there are no easy solutions to the root issue.

   But anyway, this is quite small and I understand it's a very rare use-case, I can live with doing the check in my codebase, you can close if you don't plan to include it.