Skip to content

Target make file contains syntax which is not interpreted correctly on AIX #3108

Open

Description

@ritvick
  • Node Version: node v18.20.5 , npm 10.8.2
  • Platform: AIX PPC 64
  • Compiler: gcc version 10.3.0 (GCC)
  • Module: Proprietary custom module
Target make file contains syntax which is not interpreted correctly on AIX
gyp info it worked if it ends with ok
gyp verb cli [
gyp verb cli '/home/user/user1/node-v18.20.5-aix-ppc64/bin/node',
gyp verb cli '/tmp/custom_package/node_modules/.bin/node-gyp',
gyp verb cli 'rebuild',
gyp verb cli '--verbose',
gyp verb cli '--target=v18.20.5',
gyp verb cli '--release',
gyp verb cli '--msvs_version=2019',
gyp verb cli '--buildfolder=Release',
gyp verb cli '--linux_variant=undefined',
gyp verb cli '--v8_enable_pointer_compression=false',
gyp verb cli '--v8_enable_31bit_smis_on_64bit_arch=false',
gyp verb cli '--build_v8_with_gn=false',
gyp verb cli '--enable_lto=false'
gyp verb cli ]
gyp info using node-gyp@10.2.0
gyp info using node@18.20.5 | aix | ppc64
gyp verb clean removing "build" directory
gyp verb find Python Python is not set from command line or npm configuration
gyp verb find Python Python is not set from environment variable PYTHON
gyp verb find Python checking if "python3" can be used
gyp verb find Python - executing "python3" to get executable path
gyp verb find Python - executable path is "/usr/bin/python3"
gyp verb find Python - executing "/usr/bin/python3" to get version
gyp verb find Python - version is "3.9.6"
gyp info find Python using Python version 3.9.6 found at "/usr/bin/python3"
gyp verb get node dir no --target version specified, falling back to host node version: 18.20.5

gyp verb install input version string "18.20.5"
gyp verb install installing version: 18.20.5
gyp verb install --ensure was passed, so won't reinstall if already installed
gyp verb install version is already installed, need to check "installVersion"
gyp verb got "installVersion" 11
gyp verb needs "installVersion" 11
gyp verb install version is good
gyp verb get node dir target node version installed: 18.20.5
.
.
.
.
g++ -shared -Wl ........
/bin/sh: syntax error at line 1 : `(' unexpected
gmake: Leaving directory '/tmp/custom_package/nodejs/src/custom_package/node_modules/custom_package-napi/build'
gmake: *** [custom_package.target.mk:279: Release/obj.target/custom_package.node] Error 2
gyp ERR! build error
gyp ERR! stack Error: `gmake` failed with exit code: 2

The line 279 is " $(call do_cmd,solink_module)" in the generated make file

A few lines above it are:

$(obj).target/custom_module.node: GYP_LDFLAGS := $(LDFLAGS_$(BUILDTYPE))
$(obj).target/custom_module.node: LIBS := $(LIBS)
$(obj).target/custom_module.node: TOOLSET := $(TOOLSET)
$(obj).target/custom_module.node: $(OBJS) FORCE_DO_CMD
        $(call do_cmd,solink_module)

NOTE: This works on all the other platforms linux / windows on pc, amd, arm, mac, graviton. It complains specifically for AIX.

Activity

  1. cclauss commented on Dec 6, 2024

    @cclauss
    Contributor

    What is gyp verb needs "installVersion" 11? Is that https://github.com/nodejs/node-gyp/releases v11? If not, what is v11?

  2. ritvick commented on Dec 10, 2024

    @ritvick
    Author

    Hi,
    This "installVersion" is not https://github.com/nodejs/node-gyp/releases. Its something internal coming from node headers.

  3. ritvick commented on Jan 28, 2025

    @ritvick
    Author

    Hi,
    Can someone check this why the syntax is not correctly generated for shell on AIX ?

  4. abmusse commented on Jan 28, 2025

    @abmusse

    Hi @ritvick

    /bin/sh: syntax error at line 1 : `(' unexpected

    What shell are you using? AIX defaults to use ksh but you want to use bash instead.

  5. ritvick commented on Jan 29, 2025

    @ritvick
    Author

    We are using the default shell which AIX ships with which is /bin/sh

    We have also tried getting into /bin/bash and then running node-gyp, for some reason at build step it still picks up /bin/sh

    We have also tried to override it by putting SHELL=/bin/bash before the node-gyp command but it still picks up /bin/sh

  6. abmusse commented on Jan 29, 2025

    @abmusse

    @cclauss

    Is there a way to configure the shell to use something other than /bin/sh?

    @ritvick

    Could try a couple other options:

    1. Try exporting SHELL env variable? export SHELL="/usr/bin/bash"

    2. Create /bin/sh -> /usr/bin/bash symlink on the system and test things out. Might be a good idea to save the current /bin/sh prior to creating the symlink in case you want to revert back.

      cp /bin/sh /bin/sh.bak
      ln -sf /usr/bin/bash /bin/sh
      # To revert back 
      mv /bin/sh.bak /bin/sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions