V8 started to depend on LLVM's libm #308

Activity

1. joyeecheung

   changed the title [-]`third_party/llvm-libc/src/shared/math.h` not found[/-] [+]V8 started to depend on LLVM's libm[/+] on May 12, 2026
2. joyeecheung commented on May 12, 2026

   

   joyeecheung

   on May 12, 2026

   MemberAuthor

   More actions

   @MayaLekova is going to take a look
3. targos commented on May 12, 2026

   

   targos

   on May 12, 2026

   Member

   More actions

   I mentioned this on the v8-canary Slack channel. I have made some fixes that work locally.
4. targos commented on May 12, 2026

   

   targos

   on May 12, 2026

   Member

   More actions

   Gyp change: nodejs/node@bd4661e
   node-core-utils PR: nodejs/node-core-utils#1073

   👍React with 👍1Reacted by Joyee Cheung
5. MayaLekova commented on May 12, 2026

   

   MayaLekova

   on May 12, 2026

   More actions

   Thanks for including me!

   I reproduced the missing header error locally and tried applying a change in deps/v8/third_party/llvm-libc/BUILD.gn similar to

   group("headers") {
     visibility = [ "//v8:v8_libbase" ]
     public_configs = [ ":config" ]
   }
   

   as per advice in this CL: https://chromium-review.googlesource.com/c/v8/v8/+/7828379.

   This alone didn't fix the issue (no math.h generated in deps/v8/third_party/llvm-libc/), but I think something along those lines should be the way to go. For instance deps/v8/third_party/jsoncpp/generated/version.h is maybe generated in a similar manner, but I need to look at it further (and my understanding of GN is outdated, to put it mildly).
6. joyeecheung commented on May 13, 2026

   

   joyeecheung

   on May 13, 2026

   MemberAuthor

   More actions

   Note that in Node.js we don't use gn, the builds are done through gyp.