Windows MSI installer creates doc shortcut with wrong URL #43

Activity

1. targos commented on Mar 13, 2018

   

   targos

   on Mar 13, 2018

   Member

   More actions

   @nodejs/build
2. piccoloaiutante commented on Mar 13, 2018

   

   piccoloaiutante

   on Mar 13, 2018

   Member

   More actions

   After a quick look it seems that that portion of URL is driven by DistTypeDir:

   https://github.com/nodejs/node-v8/blob/canary/tools/msvs/msi/product.wxs#L261

   And that variable is set into build.bat from server:
   

   node-v8/vcbuild.bat

   Line 344 in fecbce4

   msbuild "%~dp0tools\msvs\msi\nodemsi.sln" /m /t:Clean,Build %msbsdk% /p:PlatformToolset=%PLATFORM_TOOLSET% /p:GypMsvsVersion=%GYP_MSVS_VERSION% /p:Configuration=%config% /p:Platform=%target_arch% /p:NodeVersion=%NODE_VERSION% /p:FullVersion=%FULLVERSION% /p:DistTypeDir=%DISTTYPEDIR% %noetw_msi_arg% %noperfctr_msi_arg% /clp:NoSummary;NoItemAndPropertyList;Verbosity=minimal /nologo

   I guess it will be a matter to to set it properly into jenkins, isn't it @gibfahn ?
3. gibfahn commented on Mar 14, 2018

   

   gibfahn

   on Mar 14, 2018

   Member

   More actions

   I guess it will be a matter to to set it properly into jenkins, isn't it @gibfahn ?

   DistTypeDir is set in the ci-release job from DISTTYPE, which is a parameter in the job:

   

   It should be release for regular releases.
4. joaocgreis commented on Mar 15, 2018

   

   joaocgreis

   on Mar 15, 2018

   Member

   More actions

   DISTTYPE and DISTTYPEDIR are changed to custom by the build script when building v8-canaries (and others). The correct variable to use should be RELEASE_URLBASE.
5. targos commented on May 1, 2018

   

   targos

   on May 1, 2018

   Member

   More actions

   So what needs to be changed to fix this?
6. refack

   self-assigned this

   on Sep 16, 2018
7. targos commented on Jan 20, 2019

   

   targos

   on Jan 20, 2019

   Member

   More actions

   Is it still an issue?
8. vsemozhetbyt commented on Jan 20, 2019

   

   vsemozhetbyt

   on Jan 20, 2019

   Author

   More actions

   For the last Canary build for Windows (as of 2019-01-02), yes, the issue still exists.

   👍React with 👍1Reacted by Michaël Zasso
9. refack

   removed their assignment

   on Jun 1, 2019
10. nodejs-ci

    added a commit that references this issue on Aug 24, 2019

    deps: update npm to 6.10.3

    ...

    f769034