Repository navigation
Enable C++20 #45402
Description
Chromium is making the move: https://bugs.chromium.org/p/chromium/issues/detail?id=1284275 / https://chromium-review.googlesource.com/c/chromium/src/+/3946562
Is it something we want to do too?
/cc @nodejs/cpp-reviewers
Activity
gengjiawen commentedon Nov 10, 2022
+1 from me. I like newer cpp features .
RafaelGSS commentedon Nov 10, 2022
+1 from me too.
mhdawson commentedon Nov 10, 2022
@targos can we do that without bumping our compiler versions?
gengjiawen commentedon Nov 11, 2022
we are currently using GCC 8.3, From https://en.cppreference.com/w/cpp/compiler_support#cpp20,
Gcc 10 likely the version we need to upgrade.
Also if v8 follows chromium decision, we have no choice but upgrade our toolchain.
targos commentedon Nov 11, 2022
Maybe our current compiler versions are enough. They all have some level of partial support of C++20.
targos commentedon Nov 11, 2022
I'm trying to build locally with targos@0065fd6
targos commentedon Nov 11, 2022
tniessen commentedon Nov 11, 2022
I'd like to see this happen. Related: #44411 (comment)
jasnell commentedon Nov 11, 2022
Yes please
targos commentedon Nov 11, 2022
targos commentedon Nov 11, 2022
I created a draft PR: #45427 Feel free to push fixes to it.
gengjiawen commentedon Nov 19, 2022
Not sure v8 can goes modules, if it goes. really look forward to build time performance.
dharesign commentedon Dec 1, 2022
As noted in #45694, we need a fix for
CppHeapCreateParamsas well. Please see the detail there.24 remaining items
build: compile with C++20 support on Windows
build: compile with C++20 support on Windows
build: compile with C++20 support on Windows
build: compile with C++20 support
build: compile with C++20 support
build: compile with C++20 support