Meta migrate to react 19 #7349

Activity

1. AugustinMauroy

   self-assigned this

   on Dec 22, 2024
2. Harkunwar commented on Dec 25, 2024

   

   Harkunwar

   on Dec 25, 2024

   Contributor

   More actions

   I tried taking a stab at this and was able to successfully upgrade the repo to React 19 and everything seems to be working alright.

   Issues I faced:

   • The latest version of storybook 8.4.7 threw tons of errors, so I tried their latest beta version, 8.5.0-beta.5, which made a few components render.
   • React 18.3.1 was still being installed even after changing the version to 19.0.0 in package.json at the root node_modules. This made storybook throw tons of errors related to multiple versions of react present. Resolved it by running npm install --legacy-peer-deps as the error came from @orama/react-components not supporting 19.0.0. This install command is a bit risky though since it updated lots of other packages in package-lock.json, but overall seemed okay.
   • After this, storybook started complaining and wasn't compiling anymore, giving an error that it wasn't able to find react. After some investigation, realized it was looking for react at the root node_modules instead of node_modules at apps/site. Quick fix was to add react and react-dom with version 19.0.0 to root package.json which created a copy of react and react-dom in the root node modules.

   I think we should hold onto the upgrade before storybook releases the version 8.5.0, and @orama/react-components updates the peer dependency for react 19 support.

   👍React with 👍2Reacted by Jean Burellier and Claudio Wunder
3. AugustinMauroy commented on Dec 25, 2024

   

   AugustinMauroy

   on Dec 25, 2024

   MemberAuthor

   More actions

   Im in favour of waiting little bit. I opened an isssue on orama repo for react 19

   👍React with 👍1Reacted by Harkunwar Kochar
4. AugustinMauroy commented on Jan 31, 2025

   

   AugustinMauroy

   on Jan 31, 2025

   Last edited by AugustinMauroy

   MemberAuthor

   More actions

   News: Orama component has been updated.
   I'll test something today
5. ovflowd commented on Feb 1, 2025

   

   ovflowd

   on Feb 1, 2025

   Member

   More actions

   as the error came from @orama/react-components not supporting 19.0.0. This install command is a bit risky though since it updated lots of other packages in package-lock.json, but overall seemed okay.

   cc @micheleriva
6. ovflowd commented on Feb 1, 2025

   

   ovflowd

   on Feb 1, 2025

   Member

   More actions

   I think we should hold onto the upgrade before storybook releases the version 8.5.0, and @orama/react-components updates the peer dependency for react 19 support.

   Agreed! Also, glad to see you around, @Harkunwar ❤
7. AugustinMauroy commented on Feb 1, 2025

   

   AugustinMauroy

   on Feb 1, 2025

   MemberAuthor

   More actions

   Claudio orama side is okay !

   ❤️React with ❤️1Reacted by Claudio Wunder
8. ovflowd

   added this to Node.js Websiteon Feb 4, 2025
9. github-project-automation

   moved this to 📋 Backlog in Node.js Websiteon Feb 4, 2025
10. AugustinMauroy

    closed this as completedon Mar 1, 2025
11. github-project-automation

    moved this from 📋 Backlog to ✅ Done in Node.js Websiteon Mar 1, 2025
12. ovflowd commented on Mar 1, 2025

    

    ovflowd

    on Mar 1, 2025

    Member

    More actions

    Migration completed via #7531
13. avivkeller

    removed this from Node.js Websiteon May 3, 2025