Repository navigation
Revisit Fast APIs implementations & New implementations #182
Description
Since #23, there have been many implementations in Node using fast APIs, and I want to open this issue to encourage to revisit them and probably take a look at other places where we could implement the latest changes.
Since nodejs/node#54077, we have now support to throw errors inside fast apis, this was not possible before and we the "options.fallback" was the only way to throw errors.
We also had some limitations around int64 and bigints, and now I think those limitations was solved since I found some tests on v8 returning bigints:
- c++ ref: https://github.com/nodejs/node/blob/main/deps/v8/src/d8/d8-test.cc#L1245-L1297
- js ref: https://github.com/nodejs/node/blob/main/deps/v8/test/mjsunit/compiler/fast-api-calls-64-bit-integer-values.js#L182
I'm still trying to figure out all the limitations around these new changes, so any hints around these new changes are very welcome.
Activity
billywhizz commentedon Nov 12, 2024
i'm keen to help out with this effort @H4ad. i've done quite a lot with fast api on my own runtime and will be contributing to node.js as much as I can in period ahead. will take a look over next week or so and will add anything i think would be useful to this issue.
anonrig commentedon Nov 27, 2024
I think we should also start adding more tests to fast api paths. I've opened a PR for timers for example: nodejs/node#55905
H4ad commentedon Nov 28, 2024
I agree, I will try to open PRs related to
node_process_methods, there are some functions that I think can be converted to fast api, but I'm not sure yet, and the ones that already have fast api enabled, we can add the tests.The only issue I had around adding tests for fast api was the nodejs compilation taking more than 32GB of memory, the maximum memory used was around ~50GB.