You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add a test reading binary resources that are injected at build time #11
changed the title [-]Test reading binary resources that are injected at build time[/-][+]Add a test reading binary resources that are injected at build time[/+]on Sep 9, 2022
In theory, whether a resource is injected pre or post compilation doesn't even matter, as they both result in sections/segments appended to the binary. I believe this was raised by @dsanders11 as a way to test that the reading operation is done correctly and does not depend on quirks about how we actually inject with Postject as well.
Isn't Postject concerned only about resources that are injected post-compilation?
I would say no. The run-time API is agnostic to how the resource was added, pre or post, and I think there are valid use cases for pre, it makes things simpler and is guaranteed bug free, since it's using standard techniques.
Activity
[-]Test reading binary resources that are injected at build time[/-][+]Add a test reading binary resources that are injected at build time[/+]RaisinTen commentedon Sep 12, 2022
Isn't Postject concerned only about resources that are injected post-compilation?
jviotti commentedon Sep 12, 2022
In theory, whether a resource is injected pre or post compilation doesn't even matter, as they both result in sections/segments appended to the binary. I believe this was raised by @dsanders11 as a way to test that the reading operation is done correctly and does not depend on quirks about how we actually inject with Postject as well.
dsanders11 commentedon Sep 12, 2022
I would say no. The run-time API is agnostic to how the resource was added, pre or post, and I think there are valid use cases for pre, it makes things simpler and is guaranteed bug free, since it's using standard techniques.