Repository navigation
Premature close error on socket under Node.js 12 #477
Description
This only happens with readable-stream@4 and Node.js 12. Later versions of Node, or earlier versions of readable-stream, work fine.
'use strict'
const net = require('net')
const { pipeline, PassThrough } = require('readable-stream')
const server = net.createServer(function (sock) {
pipeline(sock, new PassThrough(), sock, function () { })
})
server.listen(3000, function () {
const sock = net.connect(3000)
// Change to false to avoid error
if (true) {
pipeline(sock, new PassThrough(), sock, (err) => {
// NodeError: Premature close
if (err) throw err
})
} else {
sock.on('connect', function () {
console.log('client connected')
pipeline(sock, new PassThrough(), sock, (err) => {
if (err) throw err
})
})
}
})
Activity
vweevers commentedon Jul 2, 2022
Happens because
sock.readableis initially false (beforeconnecthas been emitted) and this branch is hit:readable-stream/lib/internal/streams/end-of-stream.js
Lines 192 to 197 in 49a45a9
Which evaluates to:
mcollina commentedon Jul 2, 2022
I'm not sure what can we do about this.