Skip to content

interop broken #501

Open
Open

Description

@ronag

In utils we use:

const kDestroyed = Symbol('kDestroyed')
const kIsErrored = Symbol('kIsErrored')
const kIsReadable = Symbol('kIsReadable')
const kIsDisturbed = Symbol('kIsDisturbed')

But that means that using helper methods with node core stream will give incorrect results. I believe we need to also check the methods from 'stream'.

Alternatively change the core implementation to not use symbols...

Activity

  1. ronag commented on Nov 25, 2022

    @ronag
    MemberAuthor
  2. mcollina commented on Nov 25, 2022

    @mcollina
    SponsorMember

    Is there any way to get those Symbols out from Node.js core? If not, we should make some change there first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions