Repository navigation
Incompatibility with Rollup/Vite process polyfill #539
Description
Similar to #450, though in this case a polyfill is present. It looks like the process polyfill is an ES module with a default export that isn't being properly unwrapped by readable-stream.
I've set a breakpoint on the line that is causing TypeError: e.nextTick is not a function:
I can confirm that a nextTick implementation is available at both the default and process fields. Here my vite.config.ts:
import {defineConfig} from "vite";
import {nodePolyfills} from "vite-plugin-node-polyfills";
export default defineConfig({
mode: 'development',
build: {
sourcemap: true
},
plugins: [
nodePolyfills() // also tried: { globals: { process: true } }
]
});| Package | Version |
|---|---|
readable-stream |
^4.5.2 |
vite |
^5.4.2 |
vite-plugin-node-polyfills |
^0.22.0 |
rollup |
^4.21.0 |
esbuild |
^0.23.1 |
Activity
mcollina commentedon Aug 22, 2024
Thanks for reporting!
Can you provide steps to reproduce? We often need a reproducible example, e.g. some code that allows someone else to recreate your problem by just copying and pasting it. If it involves more than a couple of different file, create a new repository on GitHub and add a link to that.
WasabiThumb commentedon Aug 22, 2024
Here you are! ^_^
https://github.com/WasabiThumb/reprex-539 (non-boilerplate located here)
I've noticed that simply changing line 2 on
src/main.tsto importstreamrather thanreadable-streammakes the demo work flawlessly, but it's a shame since I thought usage ofstreamwas discouraged 😢WasabiThumb commentedon Aug 22, 2024
I've added a GitHub pages deployment, pressing the button should cause a console error.
https://wasabithumb.github.io/reprex-539/
Gitssalah commentedon Sep 30, 2024
Any apdate ?
MattiasBuelens commentedon Sep 30, 2024
This package seems to require
processin a rather odd way since #497. Notice the trailing slash:Perhaps
vite-plugin-node-polyfillsdoesn't handle this case very well?Some improvements
WasabiThumb commentedon Sep 30, 2024
I noticed #497 since it is somewhat related. I recall editing the package to replace
process/withprocessto no effect. It should be easy to reproduce with the example. That does make some sense, if it was a resolution issue I would expect Vite to raise a compile-time error. It seems to resolve properly, but provides the whole ES module rather than just the default export. That also makes sense, since that is the default behavior for require, but something is typically supposed to handle this. Either a wrapper function like__webpack_require__, or TSC adding.defaultwhen convertingimporttorequire; someone can correct me here.On the TSC note I realized that my example was missing
allowSyntheticDefaultImports. However, I added it and got the exact same issue. It can't hurt to have, so I'm pushing it to the example repo. I've also updated thevite.config.tsto only usebase: '/reprex-539'when targeting GitHub Pages, since I'm here making a commit anyways ❤️WasabiThumb commentedon Sep 30, 2024
In the absence of any new insight, I've made a brute-force fix on this branch. For what it's worth, all tests pass and it works perfectly in the reprex. To try it out:
(cc. @Gitssalah)
If this passes the bar, I could make a PR (though I imagine that this is far too opaque).
mcollina commentedon Oct 13, 2024
I'll be happy to land a PR covered by tests.
WasabiThumb commentedon Oct 14, 2024
Created #543. I should also note that the PR would not introduce any new tests, simply that it does not actively cause a regression. I'm not sure what a test for this fix would look like while also being in-scope for the project.
mcollina commentedon Oct 14, 2024
Use
viteto bundle an app and run the tests in the browser with playwright.mesqueeb commentedon Mar 20, 2025
just wanna mention this issue still exists
SystemParadox commentedon Sep 3, 2026
It would be really nice to get this fixed. It seems really odd that this doesn't work in rollup/vite, given that the entire purpose of this package is to provide readable-stream for the browser, and vite is now the most popular browser bundler.
fix: unwrap ESM-style process polyfills in internal streams (#31)