.txt.asc files are downloaded instead of displayed in browser #69

Activity

1. flakey5 commented on Nov 15, 2023

   

   flakey5

   on Nov 15, 2023

   Member

   More actions

   I believe this is because there's a difference in the content-type headers, nginx returns content-type: text/plain while R2 returns content-type: application/pgp-keys. The content type for each file is stored in R2's metadata, I don't believe we can update it after uploading but I could be wrong.

   A simple fix would be to just check if it's a .asc file when constructing the serve file response and send a text/plain content type instead of whatever R2 has it as. We already do check if it's a .json file for CORS headers
2. targos commented on Nov 15, 2023

   

   targos

   on Nov 15, 2023

   MemberAuthor

   More actions

   This one is probably not a big deal. I'm ok with just closing the issue.

   👍React with 👍1Reacted by Moshe Atlow
3. ovflowd

   added

   bugSomething isn't workingSomething isn't working

   on Nov 15, 2023
4. ovflowd commented on Nov 18, 2023

   

   ovflowd

   on Nov 18, 2023

   Member

   More actions

   I also think this is not a big deal, just funny that R2 has a different content/type for this than nginx.
5. ovflowd

   closed this as completedon Nov 18, 2023