Repository navigation
https://nodejs.org/download/release/index.* not updated for Node 21.2.0 #72
Description
URL:
https://nodejs.org/download/release/
Browser Name:
n/a
Browser Version:
n/a
Operating System:
n/a
How to reproduce the issue:
The https://nodejs.org/download/release/index.json and https://nodejs.org/download/release/index.tab files were not updated to include Node 21.2.0 that was released earlier today.
I do note that https://nodejs.org/dist/index.json and https://nodejs.org/dist/index.tab were updated.
Is this a bug in the release process? Are the old URLs deprecated and should they redirect to the /dist/ ones?
Should I update scripts that are currently using https://nodejs.org/download/release/index.tab to use https://nodejs.org/dist/index.tab instead?
Activity
ovflowd commentedon Nov 15, 2023
Too many assumptions here, but fair process of thought. No, nothing is wrong; We're making some tests in our infrastructure and switching traffic from our DigitalOcean server to Cloudflare R2 + Cloudflare Workers.
The /download/ path was being served by R2 whilst /dist is still being served by DO. We changed /download for the time being to be served once again by DO until we fix some of the current issues.
You can see the progress on https://github.com/nodejs/release-cloudflare-worker
ovflowd commentedon Nov 15, 2023
Also, kinda worrying that these paths were not updated, but I'm assuming that we have an issue where for some reason the promote script didn't promote them.
@targos is there any log from the promote script execution you can provide? @flakey5 asked if the
upload_to_cloudflare.shwas called or not 🤔targos commentedon Nov 15, 2023
There were no relevant logs.
richardlau commentedon Nov 15, 2023
It must have been called for the release assets to have been uploaded to R2, right?
targos commentedon Nov 15, 2023
I manually synced the assets after seeing that they were not on R2
targos commentedon Nov 15, 2023
I don't know if the upload script was called, but it isn't commented out in
_promote.sh:ovflowd commentedon Nov 15, 2023
Not even sure if this logic is correct. @MoLow was the one that initially implemented it, right?
MoLow commentedon Nov 16, 2023
yes, it seems correct.
ovflowd commentedon Nov 16, 2023
Can we simulate this script for v21.2.0 to see what it does? (what are the args that it passes?)
MoLow commentedon Nov 23, 2023
this seems to have been updated