Skip to content

Should https://undici.nodejs.org/ display all Node.js website announcements? #19

Closed

Description

@bmuenzenmeyer

The default doc-kit configuration for web supplies remoteConfigUrl which means undici will read https://nodejs.org/site.json and currently show the Render ATL banner.

An argument can be made that this is by design - unidici is a Node.js project. Future Node.js security announcements, etc, using the same communication vehicle will show up or not show up based on the decision here.

Image

I do want to make sure this is an active, affirmative decision.
This was brought up by @trivikr as a concern (along with making it dismissable [unrelated to this issue, and is the scope of https://github.com/nodejs/nodejs.org/issues/6292])

Activity

  1. mcollina commented on Jul 14, 2026

    @mcollina
    SponsorMember

    Added a tsc-agenda.

    I'm personally in favor.

  2. richardlau commented on Jul 14, 2026

    @richardlau
    Member

    I think community/foundation related announcements might make sense, but I think it'd be really weird to see Node.js security announcements on the Undici website. Would undici security releases get banners (if not then it'd be doubly weird to have the Node.js ones)?

  3. AugustinMauroy commented on Jul 14, 2026

    @AugustinMauroy
    Member

    IMO yess but we should add hide button.
    And yes undici can have banner and or blog posts

  4. mcollina commented on Aug 5, 2026

    @mcollina
    SponsorMember

    I spoke with the TSC today, and the answer is no, we should not include this.

  5. avivkeller commented on Aug 5, 2026

    @avivkeller
    Member

    @mcollina can you clarify whether it's "no, we should not show Node.js banners" or "no, we should not remove Node.js banners"?

  6. mcollina commented on Aug 5, 2026

    @mcollina
    SponsorMember

    no we should not show nodejs banners

  7. avivkeller commented on Aug 5, 2026

    @avivkeller
    Member

    I've made the change, this no longer shows Node.js banners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions