Repository navigation
[BUG] Circular Dependency between comparator.js and range.js #318
Description
There is a circular dependency in semver which rollup will warn about when bundling the module:
classes\comparator.js -> classes\range.js -> classes\comparator.js
Even thought this may work because of Node's resolution mechanism, I'd recommended to refactor.
Reacted by Jonas, Nick Ryan, sanmu, Mark Arseneault, Saran Tanpituckpong ✔️, Pete Thompson, Lei Nelissen, Andrew Sullivan and Synxis
Activity
isaacs commentedon Apr 19, 2020
We could maybe do this by putting the
intersectsmethod in a different file.isaacs commentedon Apr 19, 2020
Oh, actually, that's not possible, because anyone doing
require('semver/classes/comparator')will get a broken class.I think this is a legitimate case of two classes that have to reference one another, and the refactor will be rather strained. Is there a way to just tell rollup to be ok with it?
gp3gp3gp3 commentedon May 2, 2021
This throws warnings in react native projects with the metro bundler which can't be silenced unless you silence all warnings unfortunately
maietta commentedon Feb 12, 2023
Yeah, I'm still having this problem in 2023...
ilbrando commentedon Jun 5, 2024
I'm also having this issue when using rollup to build my package which uses some other packages with a dependency to semver. The semver version used is 7.6.2 (currently the latest). Is there a workaround for this bug?
WarningImHack3r commentedon Nov 21, 2025
Still a thing today, with the latest 7.7.3