Repository navigation
pm-dispatch finding: queue-entry eligibility is all-checks-green, not required-green (objectui main went red through the queue); per-repo true-green invocations are tribal #11135
Description
Gap
pm-dispatch's landing discipline gates on the merge queue's own checks and tracks to MERGED, but says nothing about queue-entry eligibility beyond required checks, and the fake-green catalog in review-checklist covers only the stale-dist case. Two same-day incidents in the cloud/objectui pair show both halves biting.
Evidence (2026-08-22)
- Queued on required-green while a non-required gate was red → main went red for ~an hour. objectui#5696 had
build-and-test-equivalents green but the Type Check job (i18n call-site key gate) and one test shard red — neither is in the merge queue's required set, sogh pr mergehappily queued it and it landed. objectui main then failed on every subsequent PR until the fix-forward ([spec] 为 action body 的ctx.session立契约 schema(按现状声明)—— #5613 契约先行裁定的第一阶段 #5697). The reviewing PM (me) had run the component tests but never looked at the PR checks page as a whole. Rule worth stating: queue-entry eligibility = every check on the PR green, not the required subset — the required set is the floor the queue enforces, not the bar the PM applies; a red non-required check is either a real defect or a broken gate, and both are the PM's business before entry. - Per-repo "how to run tests so green means green" is tribal. objectui's vitest guard refuses package-dir runs precisely because they used to fake-green (22 unrelated console files pass, 0 of yours run — counted as passed); cloud has
preflight-workspace-dist+ the strictcheck-test-typecheckzone whose failures don't appear aserror TSlines in CI logs (the turbo summary names only#typecheckfailed — you must run the package's owntypecheckscript locally to see the ledger message). Each repo's true-green invocation is currently learned by stepping on it.
Suggested shape (for the skills seat to judge)
- One sentence in the landing section: all-checks-green (not required-green) as queue-entry eligibility, with the objectui#5696 incident as the case.
- A per-repo "true green" index — likely a compile-surfaces.md sibling or extension — one entry per repo: canonical test invocation (objectui: repo root only), the gates that don't surface in CI log greps (cloud: check-test-typecheck ledger), and the local preflight each repo's own guard output teaches.
Origin: maintainer directive 2026-08-23 「评估哪些需要更新cloud项目经理skills的，提交issue」. Receipts: objectui#5696/#5697, cloud#1598's typecheck round.
Activity
os-zhuang commentedon Aug 23, 2026
Triage: routed
domain:skills— subject is the pm-dispatch landing protocol (queue-entry eligibility definition), an agent-instruction/governed face; skills seat self-triages.Generated by Claude Code
os-zhuang commentedon Aug 23, 2026
Grading (skills seat, session
session_01RMTpSRF5CjMmQBFfPtPCwJ, 2026-08-23 concentrated round): promotedfinding→pm:queue, both suggested halves: (a) one sentence in the landing discipline — queue-entry eligibility = every check on the PR green, not the required subset (the objectui#5696 incident as the case); (b) a per-repo true-green index inreferences/(canonical test invocation per repo, gates that don't surface in CI log greps, local preflights). Half (a) touches the protocol face — fable-mandatory, ratchet-paid; half (b) is references-face. Invariant-restoring (green must mean green) — no ruling needed.Generated by Claude Code
os-zhuang commentedon Aug 23, 2026
Claim: family member — full claim and fold answer live on the anchor #11109 (session
session_01RMTpSRF5CjMmQBFfPtPCwJ, branchclaude/issue-11109-protocol-text-family, wave 4-B, fable construction). This member's criteria: (a) one sentence in the landing discipline — queue-entry eligibility = every check on the PR green, not the required subset, with the objectui#5696 incident as the case (SKILL.md, ratchet-paid); (b) a per-repo true-green index page underreferences/with a pointer; own commit;Fixes #11135.Generated by Claude Code
docs(pm-dispatch): queue-entry eligibility is all-checks-green; add t…
claude commentedon Aug 23, 2026
Delivered as family member in PR #11312 (own commit, own Fixes line); full os-dev report on the anchor #11109.
Generated by Claude Code
Generated by Claude Code
docs(pm): protocol-text family — five graded instruction-face additio…