Repository navigation
[finding] guard-main-checkout-bash.sh header says "Three layers:" but now lists four — PR #11129 added layer 4 without bumping the count #11234
Description
Recorded by the objectui dev porting this file's two upstream fixes into objectui's copy (objectstack-ai/objectui#5459 + objectstack-ai/objectui#5712, one PR). Filed unassigned, in this repo because this is where the fix has to land: the two copies are declared case-for-case identical and the declared direction of travel is objectstack → objectui, so correcting it downstream first would be inventing a fix ahead of the source.
Dedup performed first: no existing card on this.
The drift
.claude/hooks/guard-main-checkout-bash.sh, header:
# Writing ABOUT the ban must never trip the ban (#4890's lesson). Three layers:
# 1. quote-aware segmentation + tokenisation — …
# 2. heredoc bodies are stripped before analysis — …
# 3. a backslash-escaped `\"` inside a double-quoted word does NOT end the quote — …
# 4. shell COMMENTS are text, not commands — …
Four items under "Three layers:". PR #10406 correctly moved the count "Two" → "Three" when it added layer 3; PR #11129 (#10570) added layer 4 and left the count alone.
Why bother filing it
Small, but this specific header is load-bearing in a way an ordinary comment is not — it is the enumerated contract a reader checks a change against, and the same header is the thing that told objectui's dev the two copies must not drift. A miscount is exactly the kind of detail that makes the next reader wonder which layer they are missing.
Precedent for treating this class as worth a card: objectstack-ai/objectui#3721, the same shape on guard-shared-stash.sh's "Self-test (26 cases)" line.
Status in objectui
Ported verbatim, miscount included, in objectstack-ai/objectui#5459's PR — deliberately, and flagged there for review — so that the two copies stay byte-identical outside the localised lines. Once this is fixed here, the correction ports downstream like any other drift item.
Suggested shape
One word: Three layers: → Four layers:. No logic, no self-test change.
Governed surface (.claude/**): draft PR, human merge.
Activity
os-zhuang commentedon Aug 23, 2026
Triage: routed
domain:skills—.claude/hooks/**is the governed agent-instruction enforcement face; skills-lane findings are self-triaged by that seat.Generated by Claude Code
os-zhuang commentedon Aug 23, 2026
Claim: family member (declared boundary-case rider) — full claim and fold answer live on the anchor #11131 (session
session_01RMTpSRF5CjMmQBFfPtPCwJ, branchclaude/issue-11131-guard-bash-pass-agreement). This member's independent criterion: header readsFour layers:; own commit;Fixes #11234line in the PR. The objectui verbatim-port follow-up (this card's "Status in objectui" note) is filed at ACCEPT.Generated by Claude Code
docs(hooks): the header enumerates four layers, not three (#11234)
claude commentedon Aug 23, 2026
Implemented as a family member in draft PR #11278 (branch
claude/issue-11131-guard-bash-pass-agreement), which carries aFixes #11234line. This member’s criterion: the header now readsFour layers:above exactly four enumerated items; own commit 1a619db. Full os-dev report lives on the anchor #11131. Governed surface: draft, human merge only.Generated by Claude Code
Generated by Claude Code
fix(hooks): make guard-main-checkout-bash agree with itself on backsl…