[finding] 11 of the 13 gates declaring ROOT_DIR_WATCH_HINTS have nothing pinning the declaration is a LITERAL — computing any of them away silently re-blinds that gate

Surfaced while fixing #12472 (PR #12759), which repaired the phantom literal-vs-computed pin in scripts/check-cli-command-ids.mjs. Filed unassigned and not touched there — that card's declared file surface is one gate, and this is a class observation across eleven others. Not a live defect: every declaration in the tree is currently spelled as a literal.

The mechanism, measured on this tree

extractWatchHints in scripts/pm/dispatch-gates.mjs reads source text, so a ROOT_DIR_WATCH_HINTS declaration written as a literal contributes a hint and the same declaration computed from the population constant contributes nothing. Measured directly against the extractor on scripts/check-cli-command-ids.mjs:

declaration spelling	subtree hints recovered
literal	`["scripts/**"]`
computed from the population constant	`[]`

A gate that loses its hint becomes unnameable by every dispatch brief and scores a quiet green for every card in the tree. That is the harm #12472 documents.

The population

Swept the 13 gates carrying a ROOT_DIR_WATCH_HINTS declaration under scripts/. Exactly two carry an own-source readFileSync(fileURLToPath(import.meta.url)) pin holding the declaration to a literal spelling:

scripts/check-cli-command-ids.mjs — the pin was phantom; fixed in fix(scripts): make check-cli-command-ids' literal-declaration self-test able to fail #12759
scripts/check-objectql-double-limit.mjs — cleared, hint spelled once, assembled needle

The remaining 11 have no such pin at all:

check-agent-test-spelling · check-comment-mask-adoption · check-driver-conformance
check-entry-guard · check-examples-live-imports · check-parse-guard
check-pnpm-filter-targets · check-published-files · check-role-word
check-skill-compatibility-version · check-skill-frame-sync

Nothing local to those files would redden if an author rewrote the declaration as a mapped expression over the population constant — which is a natural-looking tidy-up, since in every case the hint is literally the population root plus a subtree glob.

What is NOT measured here, and should be checked first

I did not measure whether the repo-level ledger gates already catch this from the other side. node scripts/pm/bare-root-worklist.mjs --self-test and pnpm check:pm-dispatch-gates both reason about gates whose population is unspelled, and it is plausible that computing a declaration away trips one of them as a STALE or CONTRADICTED verdict. If it does, this card is already covered and should be closed as such — that check is the first step, not the remedy.

Reproduce by mutating one declaration in a worktree and running both ledger gates.

If it is genuinely uncovered

The remedy the repo already prefers is one shared guard closing the whole class rather than eleven copies of a per-file pin: a check that, for every gate declaring ROOT_DIR_WATCH_HINTS, locates the declaration statement and asserts each declared hint appears inside that statement as a quoted literal. #12759 implements exactly that shape for one file and its ablation is recorded there, so the predicate is already written and measured; generalising it is mostly relocation.

Note the scoping detail that cost #12472 its enforcement: searching the whole file is not sufficient, because a gate may spell its own hint again in a neighbouring runtime-value assertion, and a whole-file includes then finds that copy and stays green. The search has to be scoped to the declaration statement.

Measured on objectstack-ai/objectstack at 168941cea.

Finding round: graded, promoted to pm:queue, finding shed. domain:devx stands (scripts/ gates). Type Task — ⛔ not a live defect, as the card says plainly: every declaration in the tree is currently spelled as a literal. What is missing is the thing that keeps it that way.

The first deliverable is the coverage check, ⛔ not the guard — and the card is right to put it there. It explicitly did not measure whether bare-root-worklist.mjs --self-test and pnpm check:pm-dispatch-gates already catch this from the other side, and says: "If it does, this card is already covered and should be closed as such." ⇒ Dispatch order:

Mutate one declaration in a worktree to the computed spelling and run both ledger gates. If either reddens (STALE / CONTRADICTED), close this card as already covered and report which gate caught it. ⭐ That is a complete and successful delivery — ⛔ do not build a guard to avoid returning empty-handed.
Only if genuinely uncovered, generalise fix(scripts): make check-cli-command-ids' literal-declaration self-test able to fail #12759's predicate to the class.

If step 2 happens, one scoping detail is the whole difficulty — carried because it is exactly what cost #12472 its enforcement: ⛔ searching the whole file is not sufficient. A gate may spell its own hint again in a neighbouring runtime-value assertion, and a whole-file includes finds that copy and stays green. The search must be scoped to the declaration statement. #12759 already implements and ablates that shape for one file, so the predicate is written and measured; generalising is mostly relocation.

⚠️ Serial constraint — scripts/pm/dispatch-gates.mjs is in flight. #12299 (pm:dispatched, domain:devx, os-zhuang, touched 19:13Z) is editing extractWatchHints — the very function whose source-text reading is this card's mechanism. ⇒ If step 2 lands the shared guard anywhere inside dispatch-gates.mjs, it collides. The claim's Serial constraints cleared: line must name #12299 explicitly and either wait or place the guard in its own file. ⛔ Do not treat "different concern" as "different file". Note also that #12299's own subject — extractWatchHints mis-handling module-relative literals — could change what step 1 measures, so re-run step 1 after #12299 lands rather than inheriting a reading taken before it.

Family context, worth stating so the class is visible: this is the third card this week on the same instrument's precision (#12472 closed 17:41Z, #12759 its fix, #12299 in flight), and the remedy the repo prefers — one shared guard closing the class rather than eleven per-file pins — is the same altitude argument this seat made on #12732 and #12730 today. If step 1 shows it uncovered, that is the shape to build.

Measured at 168941cea; ⛔ re-measure at dispatch — the population of 13 and the split of 2-with-pin / 11-without both move as gates are added.

Generated by Claude Code

Measured while working #12410 (dev seat, domain:devx lane, round 18), in a dedicated worktree at origin/main @ 632e862d1.

This card's own "check this first" question, answered: NO

This card asks, as its first step, whether node scripts/pm/bare-root-worklist.mjs --self-test or pnpm check:pm-dispatch-gates already catch a computed declaration from the other side, and says the card should be closed as covered if they do. They do not.

Reproduced exactly as prescribed here — mutate one declaration in a worktree and run both ledger gates. Target: scripts/check-objectql-double-limit.mjs, one of the two files this card lists as already carrying an own-source pin.

mutation of the `ROOT_DIR_WATCH_HINTS` statement	gate's own `--self-test`	`bare-root-worklist --self-test`	`dispatch-gates --self-test`	hints `extractWatchHints` recovers	gate in the family for a test-file card
none (base `632e862d1`)	exit 0	exit 0	exit 0	baseline.json, `packages/*/.test.ts`, n/a	yes
computed from the population constant, literal kept in a neighbouring COMMENT	exit 0	exit 0	exit 0	baseline.json, n/a	no
declaration emptied, literal gone from the file text	exit 1	exit 0	exit 0	baseline.json, n/a	no

Row 2 is the finding: all three self-tests green, the subtree hint gone, and the gate back out of every dispatch brief — the precise state #12410 was filed about. Neither ledger gate moves in any of the three rows, so neither is the coverage this card hoped for.

A correction to this card's population

scripts/check-objectql-double-limit.mjs is listed here as "cleared, hint spelled once, assembled needle". The assembled needle is real, but the SEARCH is whole-file:

const ownSource = readFileSync(fileURLToPath(import.meta.url), 'utf8');
expect('the declaration is spelled as a LITERAL in this source, not computed ...',
  ownSource.includes(declNeedle));

That is the scoping defect this card itself warns about, one source of a second copy over. check-cli-command-ids.mjs records the reasoning that made the assembled needle look sufficient for its sibling, verbatim:

That file spells the hint twice (declaration, assertion), so un-spelling the assertion leaves the declaration as the only copy.

True of the tree today, but nothing HOLDS it to be the only copy. A comment carrying the literal is a third copy, and row 2 above is that comment.

So check-cli-command-ids.mjs — statement-scoped via declSites since #12759 — is the only one of the two genuinely covered. check-objectql-double-limit.mjs belongs in the unpinned population this card enumerates, not beside it, and the predicate to generalise is #12759's declSites form rather than the assembled needle.

Method, so the greens above are readable as measurements

Both ablations were confirmed on disk before any reading was taken: the removed anchor counted to 0, and git hash-object differed from the HEAD blob a46bd2ffed9446601aacc8ceeb724877f87e0a28. Restore was proved by state — git diff HEAD empty and the blob back to a46bd2ffed94... — not by an exit code, under an absolute-path trap on EXIT/INT/TERM. Row 3 is the positive control: it proves the gate's own self-test CAN fail, so the green in row 2 is a measurement and not a broken instrument.

Not fixed under #12410 — that card's scope is its own gate's population declaration, and this is the class observation this card already owns. Nothing new filed.

Generated by Claude Code

认领 · devx lane PM — session session_01PfaSTikked61BkcsB5Rn69,round 22。
分支:claude/issue-12762-watch-hint-literal-pin。

Serial constraints cleared: triage 在上面那条评论点名的 #12299 已于 2026-08-27T19:49:47Z 关闭(PR #12780,落 a70f6d283),scripts/pm/dispatch-gates.mjs 现在没有在飞的 PR——origin/main 上该文件最近一次改动是 6f0fec3d0(#12841,本席上一轮的落地,已合并)。⇒ 串行位空出,本卡可占。

步骤 1 已经有人做完了,⛔ 不要重做:#12410 的 dev 在 round 18 已按本卡处方实测(@ 632e862d1),答案是 NO——两个账本 gate 都不覆盖:把声明改成计算形、字面量留在邻近注释里,bare-root-worklist --self-test / dispatch-gates --self-test / gate 自己的 self-test 三绿,而 subtree hint 消失。行 3 是它的正对照(声明清空 ⇒ gate 自测 exit 1),所以行 2 的绿是测量而不是坏仪器。⇒ 本卡直接进步骤 2。

⚠️ 但那次读数取自 632e862d1,之后 dispatch-gates.mjs 又落了三次(aacc248a8 #12826、ce3ea0600 #12830、6f0fec3d0 #12841)。triage 明说过「#12299 落地后要重跑步骤 1,而不是继承之前的读数」。⇒ 在 origin/main 当前 tip 上把行 2 重跑一次作为起点;若这次它反而红了,那就是「已被覆盖」,按 triage 的话关卡结案即为成功交付。

我在派发时重测的人口(⚠️ 是我的读数,不是裁决,请自行复算):

scripts/** 下声明 ROOT_DIR_WATCH_HINTS 的文件 = 13,与卡上数字一致(正则 (export )?const ROOT_DIR_WATCH_HINTS\s*=,负对照 …HINTZ 返回 1)。
另有 6 个文件只提及不声明:check-i18n-coverage · check-page-declaration-shape · check-published-readme-exports · pm/bare-root-worklist · pm/dispatch-gates · workspace-enumerator。后两个是提取器与账本,合理;前三个我没解释清楚——它们可能用我这条正则抓不到的拼写声明,那样人口就不是 13。⛔ 定人口之前先把这 6 个逐个分类,别继承我的 13。
带 own-source readFileSync(fileURLToPath(import.meta.url) 的文件今天是 3 个:check-cli-command-ids · check-objectql-double-limit · pm/bare-root-worklist。但其中 bare-root-worklist 不在人口里(它只提及不声明),而 check-objectql-double-limit 的 pin 已被 round 18 实测为整文件搜索 ⇒ 不是真覆盖。⇒ 今天的真实切分可能是 1 pinned / 12 unpinned,而不是卡上的 2/11。⚠️ 这是我的推断,请实测确认。

分派后另发详细 brief。

Generated by Claude Code

os-dev-report

{
  "issue": 12762,
  "status": "done",
  "branch": "claude/issue-12762-watch-hint-literal-pin",
  "pr": "https://github.com/objectstack-ai/objectstack/pull/12855",
  "premise_still_valid": true,
  "mcp_calls": "0 — every GitHub read and write on this run went through repo-scoped REST (probe returned 200 on this seat); no MCP GitHub tool was called",
  "population_remeasured": {
    "measured_by_me": true,
    "final_population": "15 declarations of ROOT_DIR_WATCH_HINTS repo-wide (13 under scripts/, 1 at packages/spec/scripts/build-skill-references.ts, 1 added by this PR). The card's 13 is the scripts/-only count and is correct as far as it goes; the class is not confined to scripts/.",
    "six_mentioners_classified": {
      "verdict": "all six MENTION only — none declares under any spelling. Every occurrence of the constant in all six is inside a comment or a string literal; classified line by line, not by the regex alone.",
      "scripts/check-i18n-coverage.mjs": "line 177, a line comment explaining why the idiom cannot express this gate's population",
      "scripts/check-page-declaration-shape.mjs": "line 123, a JSDoc cross-reference to check-role-word.mjs",
      "scripts/check-published-readme-exports.mjs": "line 311, a JSDoc paragraph stating explicitly that there is NO such array below and why adding one would be wrong",
      "scripts/pm/bare-root-worklist.mjs": "lines 303/318/803, inside ledger note strings",
      "scripts/pm/dispatch-gates.mjs": "12 sites, all comments or self-test strings; this is the extractor",
      "scripts/workspace-enumerator.mjs": "line 64, a comment"
    },
    "negative_control": "the same sweep for a constant that does not exist returns 0 files; positive control on each of the six is a token known present in that same file (readFileSync: 3/3/4/3/45/4 hits), and it is not a substring of the tested token",
    "split": "1 pinned / 13 unpinned among the 14 pre-existing, NOT the card's 2 / 11 and not PM's guessed 1 / 12. check-cli-command-ids.mjs is the only genuinely covered one (statement-scoped declSites since #12759). check-objectql-double-limit.mjs's own-source needle is a WHOLE-FILE search, so a comment copy satisfies it — confirmed by ablation here, not inherited from round 18.",
    "pm_hypothesis_corrections": [
      "PM's 13 is right for scripts/ but is not the class: packages/spec/scripts/build-skill-references.ts declares ROOT_DIR_WATCH_HINTS = ['skills/*/references/**'] and dispatch-gates reads that file. Repo-wide the pre-existing population is 14.",
      "PM's guessed split of 1 pinned / 12 unpinned undercounts the population by that same file; measured it is 1 / 13."
    ]
  },
  "step1_rerun_result": {
    "answer": "STILL NOT COVERED — the card does not close as already-covered; step 2 was correct to run.",
    "decisive_case": "scripts/check-objectql-double-limit.mjs, declaration computed from that file's own SCAN_ROOT with the quoted literal kept in a neighbouring comment: extractWatchHints loses packages/**/*.test.ts, and the gate's own --self-test, bare-root-worklist --self-test and check:pm-dispatch-gates all stay exit 0.",
    "measured_at": "origin/main tip 6f0fec3d0 (the three dispatch-gates landings after 632e862d1 are included); re-confirmed green on the merged tree e839a14a8",
    "coverage_is_per_file_and_incidental": [
      "check-objectql-double-limit: own 0 · bare-root 0 · dispatch-gates 0  (nothing catches it)",
      "check-entry-guard: own 0 · bare-root 0 · dispatch-gates 1 — an ad-hoc SPECIMEN pin ('check:entry-guard is MATCHED for a brand-new scripts/ file')",
      "check-role-word: own 0 · bare-root 0 · dispatch-gates 1 — a second specimen pin ('the role-word ratchet reaches the published skills catalog it declares')",
      "check-skill-compatibility-version: own 0 · bare-root 1 (a FRESH bare-root row) · dispatch-gates 0",
      "check-examples-live-imports: own 0 · bare-root 1 · dispatch-gates 1"
    ],
    "a_reading_i_first_took_and_then_disproved": "my first ablation spelled the computed form by introducing a NEW const (WATCH_ROOT = 'scripts'), which made bare-root-worklist go red for a reason that has nothing to do with this card — a new const-name/root pair joins its FRESH species. Re-run reusing each file's EXISTING population constant (or import.meta.url where none exists) separates the artifact from real coverage: entry-guard's bare-root red disappears, dispatch-gates' stays. Only the second table is reported as a measurement.",
    "method": "every mutation confirmed on disk before any reading (removed-anchor count 0, injected count non-zero, git hash-object moved off the HEAD blob), every restore proved by state (git diff HEAD empty and blob back to the HEAD hash), all under an absolute-path trap on EXIT/INT/TERM; the file was committed before the ablation so HEAD really carried the implementation"
  },
  "landing_site": {
    "chosen": "scripts/check-watch-hint-literal.mjs, a standalone gate wired as pnpm check:watch-hint-literal and run unconditionally in the Lint & Repo Gates job",
    "why_not_dispatch_gates": "three reasons, in order of weight. (1) scripts/pm/dispatch-gates.mjs is the consumer being protected and the repo's hottest serial file — three landings between the round-18 reading and this dispatch; a class guard there takes that serial slot for nothing. (2) Inside it the guard rides check:pm-dispatch-gates' single exit code behind 810 other cases, so a class failure is not separately nameable in CI. (3) A standalone gate earns its own check:* name, so the dispatch tool puts it on every scripts/ card's brief by path derivation — confirmed in the derivation output for this very diff.",
    "import_free_on_purpose": "the guard never imports dispatch-gates. Importing it would (a) run a 7000-line module body to read one constant and (b) inherit its declared inherited-population (.github/workflows) as a watch hint for this gate — a fabricated population, which the repo prices as the costlier error. The predicate needs no runtime value, so nothing is lost."
  },
  "files_changed": [
    "scripts/check-watch-hint-literal.mjs (new, 350 lines)",
    "package.json (one line: check:watch-hint-literal)",
    ".github/workflows/lint.yml (one step in Lint & Repo Gates, with the measured rationale)"
  ],
  "what_the_guard_asserts": [
    "for every declarer found by a repo-wide sweep of authored JS/TS, the right-hand side of the declaration statement is an ARRAY OF QUOTED STRING LITERALS and nothing else (templates, identifiers, calls, spreads and concatenations all rejected)",
    "the search is SCOPED TO THE DECLARATION STATEMENT and comments are masked first through scripts/js-comment-mask.mjs — the #12472 lesson, pinned by two self-test cases where the literal is spelled again in a neighbouring runtime assertion and in a comment and the computed declaration must STILL be rejected",
    "exactly one declaration site per file, else refuse rather than judge",
    "an EMPTY population is refused, not passed — 'every declaration is a literal' is vacuously true over zero declarations",
    "an empty declaration array is a violation",
    "the gate judges ITSELF: its own declaration is in the population, pinned as a self-test case",
    "deliberately NOT asserted: that a declaration is CORRECT for the roots the gate walks. That claim is local to each gate and each already pins it from its own side; this gate holds the one property none of them can hold about itself."
  ],
  "selftest_drives_itself_red": {
    "yes": true,
    "how": "literalHints ablated to accept any right-hand side (an early return of a fixed array). Injected-marker count 1, git hash-object moved off the HEAD blob d6fb425a, restore proved by state (git diff HEAD 0 bytes, blob back to d6fb425a).",
    "reading": "✗ check-watch-hint-literal self-test: 13 of 29 case(s) failed. (green before, red after) — so the 29-case green is a measurement, not a broken instrument"
  },
  "production_positive_control": {
    "how": "scripts/check-parse-guard.mjs's real declaration rewritten to the computed form WITH a comment copy of the literal beside it (the exact mutation the two ledger gates and both older whole-file pins stay green on). Anchor count 0 after, injected count 1, comment-copy count 1, hash moved off 1dee44e2; restored and proved by state.",
    "reading": "exit 1 — '✗ scripts/check-parse-guard.mjs -- the declaration is COMPUTED, not a literal array' / '✗ check-watch-hint-literal: 1 of 15 ROOT_DIR_WATCH_HINTS declaration(s) are not readable as literals.'"
  },
  "tests": "All readings on the final tree e839a14a8 (git rev-parse --short HEAD, taken from the same run). Gate union = the 28 families node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack derives for this diff (script run with NO paths, from merge-base b489d3c72) plus the 2 convention-triggered ones it names for adding a gate script — 30 gates, every one exit 0, each exit captured directly from a redirected run, never after a pipe. Repo-wide pnpm lint (eslint . --no-inline-config) exit 0, no findings — the full farm run, not a narrowed one, so no narrowing declaration is owed. Control-byte self-scan of the three changed files: 0 matches, with a printable-ASCII positive control on the same files and the same -P engine returning 324/180/4489. No pnpm test / typecheck: the diff is one .mjs gate plus JSON and YAML wiring, no package sources; check:type-check-coverage is in the union above and is green.",
  "gates_run": [
    {
      "gate": "watch-hint-literal",
      "exit": 0,
      "verdict": "✓ check-watch-hint-literal: 15 ROOT_DIR_WATCH_HINTS declaration(s), every one an array of quoted literals inside its own statement."
    },
    {
      "gate": "pm-dispatch-gates",
      "exit": 0,
      "verdict": "✓ dispatch-gates self-test: 810 cases pass."
    },
    {
      "gate": "bare-root-worklist",
      "exit": 0,
      "verdict": "OK  self-test: 46 live row(s), 39 unreachable as spelled, 39 recorded verdict(s) — none stale, none missing, none contradicted. 17 record(s) carry a spelling and every one of 9 distinct spel"
    },
    {
      "gate": "agent-test-spelling",
      "exit": 0,
      "verdict": "✓ check-agent-test-spelling: 0 violations — 391 file(s) · 4324 bare `--` token(s) · 1205 launcher-rooted run(s) · 9 separator(s) JUDGED · 5 vitest-backed script name(s) derived from 80 manif"
    },
    {
      "gate": "bash32-floor",
      "exit": 0,
      "verdict": "✓ check-bash32-floor: 22 tracked shell file(s) under scripts/**, .claude/hooks/**, .githooks/** name no bash 4+ construct outside a comment, a guarded ${VAR:-} read, or a non-command positio"
    },
    {
      "gate": "cli-command-ids",
      "exit": 0,
      "verdict": "✓ check-cli-command-ids: 287 command-id literal(s) across 103 file(s) outside packages/cli all resolve to a real command path (71 ids derived; 3 declared fixture exemptions, 0 baselined viol"
    },
    {
      "gate": "cross-package-test-inputs",
      "exit": 0,
      "verdict": "OK: 20 package(s) read outside themselves, all declared, and turbo.json hashes every declared glob."
    },
    {
      "gate": "entry-guard",
      "exit": 0,
      "verdict": "✓ check:entry-guard: 172 scripts/ file(s) — every entry guard goes through invoked-as.mjs; 128 export bindings, 126 of them inert on import (2 known-unsafe, ⛔ SHRINK-ONLY)."
    },
    {
      "gate": "node-version",
      "exit": 0,
      "verdict": "check-node-version: OK (34 setup-node step(s) across 28 workflow(s), all on Node 22)."
    },
    {
      "gate": "parse-guard",
      "exit": 0,
      "verdict": "✓ check:parse-guard: 171 scripts/ file(s) — every TypeScript parse goes through ts-parse.mjs."
    },
    {
      "gate": "pnpm-acquisition",
      "exit": 0,
      "verdict": "check-pnpm-acquisition: OK -- every job that runs pnpm acquires it first."
    },
    {
      "gate": "pnpm-filter-targets",
      "exit": 0,
      "verdict": "✓ check:pnpm-filter-targets: 140/177 `--filter` occurrence(s) across 30 file(s) resolve against 78 workspace package(s); 37 not judged (2 foreign, 15 interpolated, 20 path); 42 more in comme"
    },
    {
      "gate": "required-contexts",
      "exit": 0,
      "verdict": "✓ check-required-contexts: 6 required context name(s) pinned across 2 workflow(s); 5 instruction surface(s) scanned against 2 retired name(s) (#9491)."
    },
    {
      "gate": "shard-attestation",
      "exit": 0,
      "verdict": "✓ check-shard-attestation: 2 aggregate gate(s) count 3 declared leg(s) across 3 attesting job(s)."
    },
    {
      "gate": "stall-guard-budget",
      "exit": 0,
      "verdict": "check-stall-guard-budget: OK (28 workflow file(s), 51 job(s), 535 step(s), 7 guard-wrapped step(s); every effective cap clears its job budget by at least one stall window)."
    },
    {
      "gate": "turbo-task-graph",
      "exit": 0,
      "verdict": "OK: 22 package-scoped and 8 generic turbo task(s) judged against 78 workspace package(s) — every package-scoped one names a package that exists (or the root token \"//\") and a script it decla"
    },
    {
      "gate": "type-check-coverage",
      "exit": 0,
      "verdict": "check-type-check-coverage: OK — 65/78 workspace packages type-checked (plus the root), 13 in the DEBT ledger (382 frozen raw errors, https://github.com/objectstack-ai/objectstack/issues/4311"
    },
    {
      "gate": "workflow-status-functions",
      "exit": 0,
      "verdict": "check-workflow-status-functions: OK (scanned 28 workflow file(s), 51 job(s), 25 job-level if: expression(s); 10 read needs.*.outputs.*, all naming a status function)."
    },
    {
      "gate": "aggregator-roster",
      "exit": 0,
      "verdict": "✓ check-aggregator-roster: 3 aggregator(s) across 2 workflow(s); roster == needs: in both directions, and all 3 required-context aggregate(s) declared."
    },
    {
      "gate": "ci-filter-parity",
      "exit": 0,
      "verdict": "OK: all 109 declared cross-package glob(s) (84 unique) are covered by `core` or `crosspkg`, every `crosspkg` entry still covers one, and the `test` job's `if:` still names both filters."
    },
    {
      "gate": "cross-package-inputs-ci",
      "exit": 0,
      "verdict": "OK: 20 package(s) read outside themselves, all declared, and turbo.json hashes every declared glob."
    },
    {
      "gate": "required-contexts-patrol",
      "exit": 0,
      "verdict": "✓ check-required-contexts: 6 required context name(s) pinned across 2 workflow(s); 5 instruction surface(s) scanned against 2 retired name(s) (#9491)."
    },
    {
      "gate": "self-test-wired",
      "exit": 0,
      "verdict": "✓ check-self-test-wired: every one of the 142 script(s) CI runs that ship a `--self-test` has that self-test run by CI."
    },
    {
      "gate": "self-test-wf-commands",
      "exit": 0,
      "verdict": "✓ check-self-test-workflow-commands: no self-test CI runs prints a line the Actions runner would parse as a workflow command."
    },
    {
      "gate": "shard-attestation-ci",
      "exit": 0,
      "verdict": "✓ check-shard-attestation: 2 aggregate gate(s) count 3 declared leg(s) across 3 attesting job(s)."
    },
    {
      "gate": "step-collectors",
      "exit": 0,
      "verdict": "✓ check-step-collectors: 361 `run:` steps across 28 workflow(s); 3 step(s) run 2+ independent self-tests, all of them through a collector."
    },
    {
      "gate": "whole-set-label-write",
      "exit": 0,
      "verdict": "✓ check-whole-set-label-write: 0 violations — 221 file(s) over 3 root(s) · 11 raw mention(s) · 11 in comments/prose (cleared) · 0 in EXECUTABLE content (judged) · 152 `uses:` pin(s) over 18 "
    },
    {
      "gate": "docs-drift-comment",
      "exit": 0,
      "verdict": "✓ check-drift-comment: 56 cases pass across 5 fixture diff(s)."
    },
    {
      "gate": "pm-ci-failure-selftest",
      "exit": 0,
      "verdict": "OK  self-test: supersession keeps the newest per name and reports the drops; the four measured"
    },
    {
      "gate": "nul-bytes",
      "exit": 0,
      "verdict": "check-nul-bytes: OK (scanned 7142 text file(s) -- 7142 tracked, 0 untracked-not-ignored; skipped 7 binary; no raw ASCII control bytes)."
    },
    {
      "gate": "lint (repo-wide eslint . --no-inline-config)",
      "exit": 0,
      "verdict": "eslint exit 0, no findings printed (LINT_EXIT captured from a redirected run, never through a pipe)"
    },
    {
      "gate": "watch-hint-literal --self-test",
      "exit": 0,
      "verdict": "✓ check-watch-hint-literal self-test: 29 cases pass -- 8 computed spellings rejected, the statement-scoped search proved against runtime and comment copies of the literal beside it"
    }
  ],
  "judgment_calls": [
    "Population widened from the card's 'under scripts/' to repo-wide. The class is defined by the constant, not by a directory, and packages/spec/scripts/build-skill-references.ts is a real declarer that dispatch-gates reads. Cost: the guard's own ROOT_DIR_WATCH_HINTS is narrower than what it walks (it declares scripts/**, where 13 of 15 live). Declaring packages/** to match the walk would be the costlier error the bare-root ledger warns about, so the sweep stays repo-wide (nothing is missed silently) while the declaration stays honest and narrow. The reasoning is in the constant's docblock.",
    "The guard checks the SPELLING of a declaration, not its CORRECTNESS. Correctness is already pinned per-gate where the walked root is in scope; duplicating it here would be a second answer to a question that already has one.",
    "No end-to-end assertion against extractWatchHints in the production audit, even though it holds today for all 15 (measured: every declared literal is recovered). Adding it would require importing dispatch-gates, which fabricates a watch-hint population for this gate. The literal-array predicate is what the card prescribes and is strictly checkable without it.",
    "Fixtures in the self-test assemble the constant name from DECL_NAME rather than spelling it. The scan masks comments but not string literals, so a verbatim fixture would be found as a second declaration site in this very file and refused; a self-test case pins that this file still holds exactly one site, so a future author who forgets gets a loud failure rather than a quiet one.",
    "Ran the gate union through scripts/pm/os-verify-lock.sh as the dispatch asked, though the lock's own header lists check:* gate scripts as unlocked sibling work. Harmless; noted so the seconds in the ledger are read as shared-box seconds."
  ],
  "open_questions": [],
  "out_of_scope_findings": [],
  "out_of_scope_note": "Nothing filed. Two things I looked at and deliberately did NOT file: (a) check-objectql-double-limit.mjs's whole-file own-source needle is now redundant with this class gate, but it is not wrong and removing it is not this card's scope; (b) the two ad-hoc specimen pins inside dispatch-gates' self-test (check:entry-guard, check-role-word) look like duplicates of this gate but are NOT — they assert hint COVERAGE via hintCovers, which this gate does not. Neither is a defect, so filing either would be noise.",
  "summary": "Step 1 was re-run on the current tip rather than inherited, and the answer is unchanged: neither ledger gate covers the class. A computed declaration on scripts/check-objectql-double-limit.mjs — spelled from that file's own SCAN_ROOT, quoted literal kept in a neighbouring comment — loses its subtree hint while the gate's own self-test, bare-root-worklist --self-test and check:pm-dispatch-gates all stay exit 0. What coverage exists today is per-file and incidental (two ad-hoc specimen pins in dispatch-gates, plus a bare-root side effect), never class-level. So step 2 landed: scripts/check-watch-hint-literal.mjs holds every ROOT_DIR_WATCH_HINTS declaration in the repo to an array of quoted literals, searching only inside the declaration statement over comment-masked source, refusing an empty population, and judging itself. Both instruments are positive-controlled: the production run reddens on a real declaration rewritten to the computed form, and the 29-case self-test reddens 13 cases when its predicate is ablated. Two corrections to the card and to the dispatch brief: the class is 14 pre-existing declarations, not 13 (one lives outside scripts/), and the split is 1 pinned / 13 unpinned, not 2 / 11."
}

Generated by Claude Code

Navigation Menu

Repository navigation

[finding] 11 of the 13 gates declaring ROOT_DIR_WATCH_HINTS have nothing pinning the declaration is a LITERAL — computing any of them away silently re-blinds that gate #12762

The mechanism, measured on this tree

The population

What is NOT measured here, and should be checked first

If it is genuinely uncovered

This card's own "check this first" question, answered: NO

A correction to this card's population

Method, so the greens above are readable as measurements

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[finding] 11 of the 13 gates declaring ROOT_DIR_WATCH_HINTS have nothing pinning the declaration is a LITERAL — computing any of them away silently re-blinds that gate #12762

Description

The mechanism, measured on this tree

The population

What is NOT measured here, and should be checked first

If it is genuinely uncovered

Activity

huangyiirene commented on Aug 27, 2026

os-zhuang commented on Aug 27, 2026

This card's own "check this first" question, answered: NO

A correction to this card's population

Method, so the greens above are readable as measurements

os-zhuang commented on Aug 28, 2026

claude commented on Aug 28, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions