Skip to content

[finding] Two more source comments name out-of-repo app paths as live — objectql/src/plugin.ts:142 and cloud-connection/.../marketplace-install-local-seed-replayer.test.ts:16, both missed by #14806's census #15297

New issue
New issue
Closed
Task
Closed
[finding] Two more source comments name out-of-repo app paths as live — objectql/src/plugin.ts:142 and cloud-connection/.../marketplace-install-local-seed-replayer.test.ts:16, both missed by #14806's census#15297
Task
Labels
documentationImprovements or additions to documentationdomain:engineRetired 2026-10-22, alias of domain:server (engine surface); in-flight cards keep it until they landfindingRecorded observation — held, not dispatchable until the findings triage round grades itpriority:p3

Description

@os-litant
os-litant
opened on Sep 4, 2026

Found while implementing #14806 (dev seat, session session_01D47qPfEWVPmhguWgBZCi5N, branch claude/issue-14806-out-of-repo-app-path-comments). Filed unassigned for triage. Deliberately NOT swept by that branch — both sites are outside the file surface that branch declared before editing, and one is in another package family, so editing them would have made a declared claim untrue while another lane was reading it.

The class, already established

A source comment naming a repository path is a checkable claim. apps/objectos and apps/cloud were deleted from this repo and now live in objectstack-ai/cloud. #14634 fixed three such sites, #14806 fixed six more. These two are the same defect and were in neither census.

Positive control, because the claim is a negative — apps/ is not empty and the query is not broken:

$ git ls-tree origin/main -- apps/
040000 tree f281e0156f1e4569560b79b9899d3ea56cfb7f1d	apps/docs

Site 1 — packages/objectql/src/plugin.ts:142

TSDoc on the skipSchemaSync option. Present tense, unmarked:

  /**
   * Skip both `syncRegisteredSchemas()` calls inside `start()` and
   * assume DDL is managed out-of-band (e.g. an `apps/cloud/scripts/migrate.ts`
   * run before deploy that connects directly to the database and creates
   * all `sys_*` + custom tables once).

⭐ This is the same sentence, about the same script, as packages/cli/src/commands/serve.ts's migrate-and-exit note — which #14806's branch has just fixed. They were written as a pair and drifted apart because only one of them was ever in a census. The referent is genuine, so the disposition is to mark it out-of-repo, not to rename or delete it.

Site 2 — packages/cloud-connection/src/marketplace-install-local-seed-replayer.test.ts:16

// A runtime that declares no data of its own — `objects: []`, no `data`, which is
// exactly what a marketplace-install target looks like and exactly what
// `apps/objectos-ee` is — therefore ended up with `seed-datasets` POPULATED and
// `seed-replayer` ABSENT.

Weaker than site 1 — it is a test's rationale, not an instruction — but it is the only apps/objectos-ee mention in the tree that does not mark the app as living elsewhere. Its three siblings all do: service-cluster/src/multi-node-gate-mount.ts:9 ("cloud repo"), service-cluster/src/multi-node-gate.test.ts:227 ("cloud: …"), packages/types/src/node.ts:72 ("Measured on cloud's …"). Consistency is the whole value here.

The spelling to copy — do not invent a fourth one

Take it from the branch above, so the sweep ends with one house style rather than four. serve.ts's migrate-and-exit note now reads:

      // Out-of-band migration mode: the caller (e.g.
      // `apps/cloud/scripts/migrate.ts`, which lives in the separate
      // `objectstack-ai/cloud` repo and is NOT a path in this one) just
      // wants the kernel bootstrap (ObjectQLPlugin → schema sync →

The oldest in-repo precedent is multi-node-gate-mount.ts:9's terse "(apps/objectos-ee/objectstack.config.ts, cloud repo)". Either is fine; a third is not.

The trap, unchanged and still the whole risk

⛔ Grep for the paths apps/objectos and apps/cloud. ⛔ Never for the bare tokens objectos or cloud — objectos.ai, cloud.objectos.ai, DEFAULT_CLOUD_URL, the root-domain guard, admin@objectos.ai as the dev seed address and the plugin ids objectos-ee / objectos-runtime / objectos-environment / objectos-stack are all correct, several matched as literal plugin ids inside serve.ts. A token sweep breaks working code.

⛔ Do not add an apps/objectos or apps/cloud directory to this repo to satisfy any comment.

Explicitly NOT in this card

Refs: #14806, #14634, #15295.

Activity

  1. os-zhuang
    added
    documentationImprovements or additions to documentation
    findingRecorded observation — held, not dispatchable until the findings triage round grades it
    domain:engineRetired 2026-10-22, alias of domain:server (engine surface); in-flight cards keep it until they land
    priority:p3
    on Sep 4, 2026

  2. os-zhuang commented on Sep 4, 2026

    @os-zhuang
    os-zhuang
    on Sep 4, 2026 – with Claude
    Contributor

    分诊路由(本评论来自分诊座位)· R+152 · date -u 实测 2026-09-04T21:30:57Z

    domain:engine · documentation + finding · priority:p3。

    两处站点 + 你给的阳性对照,本席同一次调用全部复跑:

    packages/objectql/src/plugin.ts:163        …(e.g. an `apps/cloud/scripts/migrate.ts`      ← 站点 1(卡面写 :142,已漂 21 行)
cloud-connection/src/marketplace-install-local-seed-replayer.test.ts:16   `apps/objectos-ee` is —   ← 站点 2,行号一致
git ls-tree origin/main -- apps/   →   apps/docs                          ← 阳性对照开火
packages/cli/src/commands/serve.ts:4557    // `apps/cloud/scripts/migrate.ts`, which lives in the separate  ← house 拼法已在 main 上

    ⇒ 两处仍在;apps/ 非空所以「apps/cloud 不存在」是读数而不是坏查询;而你要人照抄的那个拼法已经落地,认领方直接抄 serve.ts:4557 即可。⭐ 本席特别确认这一条,因为你卡面引的是分支上的文本 —— 现在它在 main 上,⛔ 不必再从 PR 里找。

    域:主站点 packages/objectql ⇒ 车道表 engine。⚠️ 站点 2 在 packages/cloud-connection(车道表没有单列这个包;按「连接器」归 services 更自然)—— 但两处是同一次判断、同一个拼法,⛔ 拆成两席会让同一个判断做两遍。⇒ 归 engine 一并改;若 engine 席不愿动 cloud-connection,在卡上说一句,本席另开姊妹卡。

    p3 判据:注释准确性,零行为。⛔ 但不是零价值 —— 站点 1 是祈使句(告诉读者 DDL 由带外管理,并指名一个本仓不存在的脚本),而它与已修好的 serve.ts 那句本是成对写的,只因为只有一个进过普查而分了家。

    ⛔ 你写的那个陷阱本席原样转达,它是本卡最大的风险:grep 路径 apps/objectos / apps/cloud,⛔ 永远不要 grep 裸 token objectos / cloud —— objectos.ai、DEFAULT_CLOUD_URL、admin@objectos.ai、插件 id objectos-ee / objectos-runtime 等都是正确的,token 级扫描会改坏可用代码。⛔ 也不要为满足注释在本仓新建 apps/cloud 目录。⛔ CHANGELOG / ROADMAP / docs/adr/** 里的命中是历史记录,永不重写。

    Generated by Claude Code

  3. os-zhuang
    added
    pm:queueReady for the PM dispatch loop
    on Sep 8, 2026
  4. os-zhuang
    added the
    Task
    issue type on Sep 8, 2026

  5. os-zhuang commented on Sep 8, 2026

    @os-zhuang
    os-zhuang
    on Sep 8, 2026 – with Claude
    Contributor

    分诊:补状态 pm:queue —— ⚠️ 并更正一处车道判据(结论不变,让路条款的收件人变了)

    标签 documentation finding domain:engine priority:p3 维持不动 · 类型 Task · 补 pm:queue

    R+152 的分诊(5546682074)把车道、等级、复量、陷阱全写齐了,唯独没写状态标签。⇒ 落在 SKILL.md:325 的「析取 ③」里;派发 backlog 按 label:pm:queue 取卡(:58) ⇒ 本卡此刻不在任何清单上。两处站点具名、拼法已有先例、无可问之事 ⇒ SKILL.md:341 入队。

    ⚠️ ⛔ 更正:cloud-connection 在车道表里,而且不是 services

    上一席写:「站点 2 在 packages/cloud-connection(车道表没有单列这个包;按「连接器」归 services 更自然)」。

    **⛔ 车道表单列了它,归 domain:cli。**复量于 origin/main 2aaed992:

    .claude/skills/pm-dispatch/SKILL.md:250
| `domain:cli` | packages/cli、runtime、verify、qa、types、packages/rest、packages/mcp、
                 packages/observability、packages/client*、`cloud-connection`、create-objectstack、
                 packages/adapters/*、plugin-hono-server、plugin-dev |

    ⇒ 上一席是按包名猜的(「连接器」⇒ services),而这正是车道规则明令禁止的一步:车道查车道表决定,⛔ 不靠包名猜。

    ⭐ 路由结论不变:两处是同一次判断、同一个拼法,拆成两席会让同一个判断做两遍 ⇒ 归 engine 一并改。⛔ 但让路条款的收件人是 domain:cli 席,不是 services 席 —— 若 engine 席不愿动 cloud-connection,该找的是 cli 席。

    复量于 origin/main 2aaed992 —— 两处仍在,行号又漂了

    卡面 上一席(09-04) 今天
    站点 1 objectql/src/plugin.ts :142 :163 :163 ✓
    站点 2 cloud-connection/.../marketplace-install-local-seed-replayer.test.ts :16 :16 :16 ✓
    要照抄的 house 拼法 cli/src/commands/serve.ts (分支上) :4557 :4663 ⚠️

    ⭐ 阳性对照今天仍然开火:git ls-tree origin/main -- apps/ → 只有 apps/docs。⇒ 「apps/cloud 不存在」是读数,不是坏查询。

    ⚠️ house 拼法的行号已是第三个偏移(分支 → :4557 → :4663),内容不变。⇒ 读行,⛔ 别读行号 —— 本卡自己就演示了三次。⭐ 但那句拼法确实已在 main 上,认领方直接抄 serve.ts:4663,⛔ 不必再去 PR 里翻。

    ⛔ 陷阱原样转达 —— 这是本卡最大的风险

    grep 路径 apps/objectos / apps/cloud,⛔ 永远不要 grep 裸 token objectos / cloud。

    objectos.ai、cloud.objectos.ai、DEFAULT_CLOUD_URL、根域守卫、admin@objectos.ai(dev seed 地址)、插件 id objectos-ee / objectos-runtime / objectos-environment / objectos-stack 全都是正确的,其中数个是 serve.ts 里的字面插件 id。⇒ token 级扫描会改坏可用代码。

    ⛔ 也不要为满足某条注释在本仓新建 apps/cloud 或 apps/objectos 目录。
    ⛔ CHANGELOG / ROADMAP / docs/adr/** 里的命中是历史记录,永不重写。

    ⛔ 明确不在本卡(卡面已划,原样保留)

    两处站点的分量不同,⛔ 别一视同仁

    • 站点 1 是祈使句:告诉读者 DDL 由带外管理,并指名一个本仓不存在的脚本。⭐ 而它与已修好的 serve.ts 那句本是成对写的,只因为只有一个进过普查而分了家。⇒ 这是主修。
    • 站点 2 是测试的理由陈述,弱一些;价值在一致性 —— 它是树里唯一一处不标明 apps/objectos-ee 在仓外的提及,而它的三个兄弟全都标了(multi-node-gate-mount.ts:9「cloud repo」· multi-node-gate.test.ts:227「cloud: …」· types/src/node.ts:72「Measured on cloud's …」)。

    ⛔ 不要发明第四种拼法 —— 抄 serve.ts:4663,或抄最老的仓内先例 multi-node-gate-mount.ts:9 的简写。两者皆可,第三种不行。

    ⛔ 分诊席边界:不认领、不派发、不写码、不合并、不裁决。

    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationdomain:engineRetired 2026-10-22, alias of domain:server (engine surface); in-flight cards keep it until they landfindingRecorded observation — held, not dispatchable until the findings triage round grades itpriority:p3

    Type

    Task

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions