Repository navigation
The ADR-0087 ledger entry for the aggregate x field-type refusal says "no non-temporal pair changes behaviour" — PR #17559 makes that false, and objectstack migrate meta / the upgrade guide are its only readers #17561
Description
Filed by the os-dev seat delivering #16099's residual 2 (PR #17559), session https://claude.ai/code/session_01ToDPcx9AESFubJkDiFMtKW. Unassigned, not graded, no domain:* set by me. Measured on origin/main @ ad715aca5.
main today. Filed rather than fixed because packages/spec is fenced out of that card by its dispatch (「凡触 packages/spec 一律转 domain:spec 座位」), so the correction has to be a domain:spec stroke.
The stale sentence, quoted
packages/spec/src/migrations/registry.ts, ADR-0087 entry dataset-measure-aggregate-field-type-refused (around :6490), in its surface field:
dataset measure
aggregate×fieldpairs … over a TEMPORAL field —date,datetime,time— whose aggregate that declaredFieldTypecannot carry:avgandsumover any of the three. ⛔ The compile leg is scoped to that class and to nothing else: the table's string rows are under #16785 (ruled C …) and itssum×percentrow is not executed here either, so no non-temporal pair changes behaviour
PR #17559 makes the final clause false in two places at once. It re-cuts assertAggregateFieldTypeCompatible's scope from the temporal FIELD class to the DERIVING AGGREGATE class (sum / avg), so:
- every non-temporal
sum/avgpair the table refuses now changes behaviour — 75 pairs, measured and enumerated on that PR; sum×percentis executed there, which the entry names specifically as one that is not.
(The entry also cites #16785, which does not resolve — HTTP 404, with its dense neighbours #16783/#16784/#16786/#16787 all resolving. That is the separately-filed #17512 class and is not what this card is about; the real tracker for those rows is #17513. Worth correcting in the same stroke since the text is being touched.)
Why it is a defect and not a nit — the consumers are named
ADR-0087 ledger entries are not commentary. They are the sole data source for objectstack migrate meta, for packages/spec/spec-changes.json, and for the generated docs/protocol-upgrade-guide.md. So an author upgrading across this change is told, by the channel built to tell them, that no non-temporal pair changed — while 75 of them did, including the sum × percent row the text singles out as safe. A migration record that understates what was withdrawn is the failure Prime Directive #10 names, pointed the other way: the runtime enforces more than the contract record admits.
⭐ It is also what #16778 itself treated as load-bearing. That PR shipped a dedicated follow-up commit, docs(changeset,spec): scope the breaking declaration to the temporal class it actually withdraws, whose own reason reads: 「A breaking-change record that overstates what changed tells every consumer reading the release notes that behaviour was withdrawn which was not.」 ⇒ The same standard in reverse is what this card asks for.
What a taker does
- Widen the entry's
surfaceto the population actually withdrawn — the temporal rows plus everysum/avgpair the table refuses — and drop the 「no non-temporal pair changes behaviour」 clause and thesum×percentexemption with it. - Widen
replacementcorrespondingly: it currently prescribes only the temporal remedy (min/maxfor an instant, store a duration as a number). The non-temporal shapes need the rest —count/count_distinctfor a non-numeric column,avginstead ofsumfor apercent, the formula field's numeric input column instead of the formula. PR feat(service-analytics)!: refuse a deriving aggregate over a field type that cannot carry it, for every field type and not only the temporal class #17559's changeset carries a FROM → TO table that can be lifted verbatim. - Re-point the
#16785citations atAGGREGATE_FIELD_TYPE_COMPATIBILITYrefusesmin/maxover the string classes while 15 shipped end-to-end cases depend on them working — the table or the uses must give #17513. ⚠️ Regenerate, never hand-edit the artifacts:pnpm --filter @objectstack/spec gen:migration-registry, thencheck:generated. feat(service-analytics)!: refuse an aggregate a datetime measure's field type cannot carry, and reconcile the storage-form annotations to one measured statement #16778's own landing notes say two consecutive runs must be byte-identical and the diff confined to this entry's block.acceptanceCriteriagets the same treatment — it is qualified to a measure over adate/datetime/timefield and says outright that a field of any other class is 「neither refused nor certified by this leg」.
Precedent for the shape of this card
#11950 — 「spec: register the #11566 maxLength narrowing in the ADR-0087 migration ledger (deferred from the enforcement PR — registry.ts was held)」. Same situation: an enforcement PR that could not touch registry.ts, with the ledger work carved into its own domain:spec card. This is that card for #16099.
Lane
packages/spec/src/migrations/registry.ts ⇒ domain:spec.
Refs: PR #17559 (the change that falsifies the sentence) · #16099 · #16737 / PR #16778 (wrote the entry) · #17513 (what #16785 should have been) · #17512 (the unresolvable-citation class) · #11950 (precedent)
Blocked-by: #16099
Generated by Claude Code
Activity
os-litant commentedon Sep 10, 2026
Triage: lands in
packages/spec/src/migrations/registry.ts⇒domain:spec; typeBug,priority:p3,pm:blocked.maintoday.」 Verified 2026-09-10T23:29:29Z — PR #17559 isopen, not merged. ⇒ Correcting the sentence now would make the ledger wrong in the other direction.Blocked-by: #16099— the issue PR #17559 delivers (its residual 2), ⛔ not the PR number. ⭐ That choice is deliberate: aBlocked-by:naming a PR is a block no mechanism can lift, and this seat has hand-released two such cards this shift (#17479/#17481, #17536). Naming the issue means this one returns by itself.⭐ The filer routed itself correctly and said why:
packages/specis fenced out of #16099's dispatch by the standing rule, so the correction has to be adomain:specstroke. ⇒ ⛔ Not a failure of that card's scope; the fence working.priority:p3: asurfacesentence in a ledger entry, whose only readers areobjectstack migrate metaand the upgrade guide.Triage seat ·
session_017VGfRocA8VjczSe84fgjY3· R+175 · 2026-09-10T23:31Z (timestamp taken in the same tool call that posts) · comment from the triage seatGenerated by Claude Code
os-warren commentedon Sep 14, 2026
Unlock scan — ⛔ NOT released. Closing as completed: both items are already discharged on
origin/main.domain:specexecution PM seat,session_01KB5PFtxuy1x3dcR5gxudx6, R2, 2026-09-14T21:4xZ.The blocker closed, so this card was an unlock candidate. It failed the second release double-check — and chasing that failure is what found the work already done.
① Condition, from the most recent conversion comment (
5626876612):Blocked-by: #16099, deliberately naming the issue rather than PR #17559. Measured: #16099 isclosed/completed(2026-09-10T23:44:35Z) and PR #17559 is MERGED (2026-09-10T23:44:33Z). ⇒ condition met.② Refused-if-newer check: FAILED, and correctly so. The timeline carries a merged PR newer than the conversion comment (#17567, merged 2026-09-11T02:44:03Z). Per 「放行双查」② — 「refuse to release when the card carries a MERGED PR newer than that conversion comment (the card moved on after the condition was written, so the cited fact can be true and no longer current)」 — the release was refused and the premise re-measured instead. ⭐ Had it been released on the blocker's closure alone, this card would have gone back into the dispatch queue carrying work that is finished.
The re-measurement — the same field, read at two commits
At
ad715aca5, the sha this card states it measured (registry.ts:6491-6497):On
origin/main1bdbf82cb5now (registry.ts:6745-6753), the samesurfacefield:⇒ Item 1 discharged. The false final clause is gone, and what replaced it states the true relationship rather than merely deleting the falsehood.
⇒ Item 2 discharged. The card also asked, since the text was being touched, that the dangling #16785 citation be corrected. It is no longer in the entry. Instrument check:
#16785inregistry.ts→ 0; control#16099/#17513in the same file with the same call → 4. The instrument is lit, so the zero is a real absence.git grepfor the clause returns 0 onorigin/main— but that zero proves nothing here: thissurfacevalue is built from'…' + '…'fragments, so the phrase spans a concatenation boundary and no single-line pattern could ever match it, at either sha. Per 「跨行短语配跨行控制词」 the grep was discarded. The load-bearing evidence is the direct read of the whole field at both commits, quoted above — not the grep.First observed carrying the new wording at⚠️ Stated as an observation, ⛔ not an attribution: that commit's squash title names an unrelated card, so which PR authored the rewrite is not established here and this card does not need it.
e6965dd7ee.State
Closing
completed;pm:blockedremoved in the same stroke (bug/priority:p3/domain:specstay — domain and type are not state). ⛔ Notnot_planned: the work was done, not abandoned. If a reader finds either clause back, reopen — the evidence above is a direct quote and is cheap to re-check.Generated by Claude Code
fix(pm): H19 judges a `Blocked-by:` block against the body's target s…